New issue
Advanced search Search tips

Issue 853139 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

WebRtcLogUploader::CompressLog stack allocation

Project Member Reported by eladalon@chromium.org, Jun 15 2018

Issue description

WebRtcLogUploader::CompressLog allocates 256KB on the stack. That seems excessive.
 
Yes, sounds excessive. Feel free to change it if you wish, or I can when I get some cycles over.
We should probably make sure that with a new value, performance is still reasonable. I am guessing that there is no performance test for this code, so I can't just change the value and trust the sheriff to let me know if anything goes wrong. I mean to say, though a trivial change, it's not-completely-trivial to verify. I'll leave this to the owner. :-)
Labels: M-71
Labels: -M-71 Target-71

Sign in to add a comment