New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 721414



Sign in to add a comment

network_service_browser_tests failing on chromium.win/Win 7 Tests x64 (1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 15

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rhalavati@chromium.org

LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden failing on chromium.win/Win 7 Tests x64 (1)

Builders failed on: 
- Win 7 Tests x64 (1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29


 
Labels: OS-Windows
Owner: karandeepb@chromium.org
Status: Assigned (was: Available)
Assigning to test author.

Karan,

Could you please take a look?
I am disabling the test for Windows.
Ramin: Fist of all, thank you, for taking the sheriffing seriously and disabling flaky tests!

One request: Can you make sure that the error is copied into the bug report. Your link is not helpful as it only points to a bot and the bug owner cannot figure out what happened when you reported the bug.

Here is the relevant information:

https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8943672073101521584%2F%2B%2Fsteps%2Fnetwork_service_browser_tests%2F0%2Flogs%2FLocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden%2F0
[ RUN      ] LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden
[4640:7824:0615/002747.842:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[4640:8068:0615/002747.842:WARNING:chrome_browser_main_win.cc(653)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden --single_process --test-launcher-bot-mode --test-launcher-filter-file=../../testing/buildbot/filters/mojo.fyi.network_browser_tests.filter --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir10360_26808\results10360_10721\test_results.xml" --test-launcher-summary-output="e:\b\swarm_slave\w\ioaogh0z\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir10360_26808\d10360_15612" --disable-offline-auto-reload --disable-renderer-backgrounding --google-base-url=https://127.0.0.1:64150/ --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=NetworkService,TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[4640:10376:0615/002748.330:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /async/ddljson?async=ntp:1
[4640:10376:0615/002748.330:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /async/newtab_ogb?hl=en-US&async=fixed:0
[4640:10376:0615/002748.345:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /async/newtab_ogb?hl=en-US&async=fixed:0
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	std::_Tree<std::_Tset_traits<extensions::UsbDevicePermissionData,std::less<extensions::UsbDevicePermissionData>,std::allocator<extensions::UsbDevicePermissionData>,0> >::_Erase [0x0000000140363C55+7]
	std::_Tree<std::_Tset_traits<extensions::UsbDevicePermissionData,std::less<extensions::UsbDevicePermissionData>,std::allocator<extensions::UsbDevicePermissionData>,0> >::erase [0x0000000140363BBD+153]
	std::_Tree<std::_Tset_traits<extensions::UsbDevicePermissionData,std::less<extensions::UsbDevicePermissionData>,std::allocator<extensions::UsbDevicePermissionData>,0> >::~_Tree<std::_Tset_traits<extensions::UsbDevicePermissionData,std::less<extensions::Us [0x0000000140362C39+39]
	extensions::WebRequestProxyingURLLoaderFactory::~WebRequestProxyingURLLoaderFactory [0x0000000141C7716D+53]
	extensions::WebRequestProxyingURLLoaderFactory::`scalar deleting destructor' [0x0000000141C7725C+16]
	std::_Tree<std::_Tset_traits<std::unique_ptr<network::WebSocket,std::default_delete<network::WebSocket> >,base::UniquePtrComparator,std::allocator<std::unique_ptr<network::WebSocket,std::default_delete<network::WebSocket> > >,0> >::_Erase [0x00000001415295E1+53]
	extensions::WebRequestAPI::ProxySet::Shutdown [0x0000000141C61E6C+30]
	base::debug::TaskAnnotator::RunTask [0x00000001427532E5+309]
	base::MessageLoop::RunTask [0x0000000142772A6C+572]
	base::MessageLoop::DoWork [0x0000000142772FC8+408]
	base::MessagePumpForIO::DoRunLoop [0x0000000142774A4A+330]
	base::MessagePumpWin::Run [0x0000000142773D58+104]
	base::RunLoop::Run [0x0000000142795621+49]
	content::BrowserProcessSubThread::IOThreadRun [0x00000001416A718A+36]
	base::Thread::ThreadMain [0x00000001427AEAE0+384]
	base::PlatformThread::GetCurrentThreadPriority [0x00000001427AD554+388]
	BaseThreadInitThunk [0x00000000776E59CD+13]
	RtlUserThreadStart [0x000000007791B891+33]

Cc: karandeepb@chromium.org yhirano@chromium.org
Components: Internals>Services>Network
Labels: -Pri-2 Test-Disabled Pri-1
Owner: roc...@chromium.org
I think that the right people to look into this are rockot@ and yhirano@ who authored the WebRequestProxyingURLLoaderFactory.
Blocking: 721414
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/487b9a8e3b4380ed4d1e6a7085aa1b8ebde028ee

commit 487b9a8e3b4380ed4d1e6a7085aa1b8ebde028ee
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Jun 15 08:21:28 2018

Disable flaky test on Win7.

Disabling flaky test on Windows:
LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden

Bug:  853118 
Change-Id: I1cff832a48bdad86239fba26bd12d830c20c55f3
TBR: battre@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1101688
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567576}
[modify] https://crrev.com/487b9a8e3b4380ed4d1e6a7085aa1b8ebde028ee/chrome/browser/extensions/api/web_request/web_request_apitest.cc

Kent, should this be disabled via testing/buildbot/filters/mojo.fyi.network_browser_tests.filter instead?
Labels: -Sheriff-Chromium
Owner: ----
Status: Available (was: Assigned)
Labels: Proj-Servicification-Canary Hotlist-KnownIssue
Cc: penghuang@google.com roc...@chromium.org feuunk@chromium.org
 Issue 856187  has been merged into this issue.
Labels: OS-Linux Type-Bug
This is also happening on linux as reported in  issue 856187  which was just marked as a duplicate of this one.
Incoming disabling of this test on Linux: https://crrev.com/c/1121114
Cc: -roc...@chromium.org
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52de04e60c04876dc0e794fda613cc36ac10e1d5

commit 52de04e60c04876dc0e794fda613cc36ac10e1d5
Author: Carlos Knippschild <carlosk@chromium.org>
Date: Fri Jun 29 21:44:18 2018

Disable OneGoogleBarRequestsHidden on Linux

TBR=battre@chromium.org

Bug:  853118 
Change-Id: I4bec34e74ef14fbe8fc7ff17c6d6db51d343e7e1
Reviewed-on: https://chromium-review.googlesource.com/1121114
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571650}
[modify] https://crrev.com/52de04e60c04876dc0e794fda613cc36ac10e1d5/chrome/browser/extensions/api/web_request/web_request_apitest.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b68bf24329db1568ae9ad6e06410583f062f983

commit 1b68bf24329db1568ae9ad6e06410583f062f983
Author: Dominic Battre <battre@chromium.org>
Date: Tue Jul 03 17:46:48 2018

Proper disabling LocalNTPInterceptionWebRequestAPITest test

Disable LocalNTPInterceptionWebRequestAPITest.OneGoogleBarRequestsHidden when
run in servicified network stack but not otherwise. Flakes are caused due to a
bug in the servicified network stack, the test seems to work well on other
platforms.

Bug:  853118 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I02bf111449dd88c24c788d630e8e53f364e03265
Reviewed-on: https://chromium-review.googlesource.com/1123822
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572278}
[modify] https://crrev.com/1b68bf24329db1568ae9ad6e06410583f062f983/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/1b68bf24329db1568ae9ad6e06410583f062f983/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Owner: jam@chromium.org
Status: Started (was: Available)
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4072ab48cadcd3f98481be63bdd59e5c623729d

commit b4072ab48cadcd3f98481be63bdd59e5c623729d
Author: John Abd-El-Malek <jam@chromium.org>
Date: Thu Jul 12 15:25:12 2018

Fix crash with webRequest and network service when duplicate request IDs are seen.

The cause in this case was SimpleURLLoader always using a request ID of 0. These requests don't go through auth anyways (since there's no tab to associate them with). Gracefully handle this in WebRequestProxyingURLLoaderFactory by not crashing.

Bug:  853118 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I856259f76caf67d7d6c0b8e48535cd56419ead1a
Reviewed-on: https://chromium-review.googlesource.com/1133692
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574567}
[modify] https://crrev.com/b4072ab48cadcd3f98481be63bdd59e5c623729d/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
[modify] https://crrev.com/b4072ab48cadcd3f98481be63bdd59e5c623729d/extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
[modify] https://crrev.com/b4072ab48cadcd3f98481be63bdd59e5c623729d/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Status: Fixed (was: Started)

Sign in to add a comment