New issue
Advanced search Search tips

Issue 853117 link

Starred by 2 users
Status: Fixed
Owner:
serg...@chromium.org
Closed: Jun 2018
Cc:
machenb...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

V8: Step stayed green despite failure

Project Member Reported by machenb...@chromium.org, Jun 15 2018 
See:
https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/20869
Look for Test262 - code_serializer (flakes)

It should be red, but is green, despite reporting an error and making the overall recipe fail. Can this be connected to the switch of this builder to LUCI? Otherwise, nothing changed in the recipe lately.

Comment 1 by machenb...@chromium.org, Jun 15 2018

Owner: machenb...@chromium.org
Status: Assigned (was: Untriaged)
Hmm, possible that this has to do with dynamic test configurations. The failing test step comes from one:
https://cs.chromium.org/chromium/src/v8/infra/testing/builders.pyl?type=cs&q=code_serializer+file:%5Esrc/v8/+package:%5Echromium$&g=0&l=379

Maybe when reporting a flake step, the test info isn't looked up correctly.

Comment 2 by serg...@chromium.org, Jun 15 2018 

Please see http://shortn/_kBCFN66FQm. Looks like WARNING (yellow) status is not supported for steps on LUCI. We can also mark steps that detect flakes as FAILURE (red).

Comment 3 by machenb...@chromium.org, Jun 19 2018 

No I think we can't. They are warnings, so that gatekeeper doesn't close the tree.

And I'm not sure if we can teach gatekeeper something generic as it doesn't support full regexps. The step name are different, dependent on the previous step name. Though, we could work around that by using the same step name for flake reports in the recipe.

Comment 4 by machenb...@chromium.org, Jun 19 2018 

Is there an upstream bug for missing warmings in LUCI? I guess we should have one either way.

Comment 5 by serg...@chromium.org, Jun 19 2018

Cc: -serg...@chromium.org machenb...@chromium.org
Owner: serg...@chromium.org
Status: Fixed (was: Assigned)
Gatekeeper supports globs, therefore I've changed step to be marked as FAILURE and added a gatekeeper. rule to ignore "* (flakes)" in https://crrev.com/c/1105764. The issue 854099 is tracking adding support for WARNING in LUCI.
►

Sign in to add a comment