New issue
Advanced search Search tips

Issue 853099 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: ----



Sign in to add a comment

components_unittests failing on chromium.memory/Mac ASan 64 Tests (1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 15 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of keishi@google.com

components_unittests failing on chromium.memory/Mac ASan 64 Tests (1)

Builders failed on: 
- Mac ASan 64 Tests (1): 
  https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29


 

Comment 1 by keishi@chromium.org, Jun 15 2018

Components: Platform>DevTools>Memory
Labels: OS-Mac
Owner: erikc...@chromium.org
Status: Assigned (was: Available)
I don't see any related CLs in the regression range
https://chromium.googlesource.com/chromium/src/+log/129f7f0e23081ac80baa3c5d4bcba88f70cb580e%5E..f0bc31531aed4dbabdf26b1bbc4c04109d1f2111?pretty=fuller&n=

Assigning to test owner.
Labels: Pri-1
We shouldn't run ProfilingJsonExporterTest.MemoryMaps on ASAN. The test iterates through the virtual address space and makes allocations for every memory region. ASAN will potentially, on each allocation, make a new memory region. Infinite loop.
Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2d563023e41006df4757effcbf69e81a32af4f8

commit a2d563023e41006df4757effcbf69e81a32af4f8
Author: erikchen <erikchen@chromium.org>
Date: Fri Jun 15 18:38:22 2018

Disable ProfilingJsonExporterTest.MemoryMaps for ASAN builds.

The test iterates through the virtual address space and makes allocations for
every memory region. ASAN will potentially, on each allocation, make a new
memory region. Infinite loop.

Bug:  853099 
Change-Id: I5e8baf2ee66ba233f14eeb28909347b41731cb78
Reviewed-on: https://chromium-review.googlesource.com/1102722
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567743}
[modify] https://crrev.com/a2d563023e41006df4757effcbf69e81a32af4f8/components/services/heap_profiling/json_exporter_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment