"GestureDetector.StartTouchMoveAndRelease" is flaky |
||||
Issue description"GestureDetector.StartTouchMoveAndRelease" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihHZXN0dXJlRGV0ZWN0b3IuU3RhcnRUb3VjaE1vdmVBbmRSZWxlYXNlDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 18 2018
Seems to be failing on the trybots about once per day since 2018-06-04, but no failures on the waterfall. Assigning to author, and taking out of the sheriff queue for now.
,
Jun 18 2018
Turns out there *are* some failures on the waterfall, on linux-xenial-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel?limit=200 3 failures in the last 200 runs right now: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/988 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/874 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/836
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7ff3bdaed5612a2281dcd36287f16822fb8410a commit f7ff3bdaed5612a2281dcd36287f16822fb8410a Author: Aldo Culquicondor <acondor@chromium.org> Date: Mon Jun 18 17:04:06 2018 VR: Remove dependence of gesture detector on TimeTicks::Now The gesture detector extrapolates scrolling events from previous real scrolling events. The extrapolated event depends on the time difference between the events, favoring the longest and more recent event. Here, we make the gesture detector receive the current time instead of querying it from the system, and thus making the tests deterministic. Bug: 853086 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2d46f5e5ebceb801aecccf5b2c0a2dbf6b858864 Reviewed-on: https://chromium-review.googlesource.com/1104583 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#568043} [modify] https://crrev.com/f7ff3bdaed5612a2281dcd36287f16822fb8410a/chrome/browser/android/vr/vr_controller.cc [modify] https://crrev.com/f7ff3bdaed5612a2281dcd36287f16822fb8410a/chrome/browser/vr/gesture_detector.cc [modify] https://crrev.com/f7ff3bdaed5612a2281dcd36287f16822fb8410a/chrome/browser/vr/gesture_detector.h [modify] https://crrev.com/f7ff3bdaed5612a2281dcd36287f16822fb8410a/chrome/browser/vr/gesture_detector_unittest.cc
,
Jun 18 2018
,
Jul 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Jun 15 2018