Tested the issue on chrome reported version# 67.0.3396.87 using Ubuntu 14.04 with steps mentioned below:
1) Launched chrome reported version and unzipped(provided in comment#0) and placed the file on desktop
2) Created a local server with 'python serv.py', and on reported chrome build visited localhost:8000
3) Seen 'TEST' on chrome window, after reloading the page didn't observed any change in the behaviour
Observations: Opened Dev-tools and observed 'Uncaught TypeError' message on console tab

@Reporter: Please find the attached screencast for your reference and let us know if we missed anything in reproducing the issue, if possible could you please provide the screencast of the issue which helps us in better understanding and further triaging it.

Thanks!

Deleted: 853085.ogv 3.4 MB

	853085.ogv 3.4 MB View Download

I think the behavior has been changed due to off-main thread fetch.
RenderFrameImpl::WillSendRequest() used to attach the header, but probably we don't have it for fetch contexts.
https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?type=cs&sq=package:chromium&g=0&l=4618

Bumped up to P1 since it's regression.

The recorded video did not include headers printed by the server. Including the result printed by the webserver for completeness.

First Request when no service worker is registered
===================================================
Host: localhost:8000
Connection: keep-alive
User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36
DNT: 1
Accept: image/webp,image/apng,image/*,*/*;q=0.8
Referer: http://localhost:8000/
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9


Second request(reload) but this time the service worker is active and intercepting requests
=====================
Host: localhost:8000
Connection: keep-alive
Cache-Control: max-age=0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8
Upgrade-Insecure-Requests: 1
User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9



You can notice the DNT header missing in the second request.

shimazu@
> I think the behavior has been changed due to off-main thread fetch.

Off-main thread fetch from worker was enabled from M62.  crbug.com/443374 


I think this is due to this change 7cf9f94ce0b49c22dfed90bc685514416c308e87 which landed in 67.0.3365.0.

Before this CL, the DNT header was set by ChromeNetworkDelegate::OnBeforeURLRequest() in the browser process.
https://chromium-review.googlesource.com/c/chromium/src/+/953077/7/chrome/browser/net/chrome_network_delegate.cc

After this CL, the header is set by RenderFrameImpl::WillSendRequest() in the renderer process main thread.
https://chromium-review.googlesource.com/c/chromium/src/+/953077/7/content/renderer/render_frame_impl.cc
But the header is not set for the requests from the worker threads.

Oops, thanks!
I didn't think RenderFrameImpl::WillSendRequest() is modified more recently.

shimazu, dxie: Does this bug occur even when NetworkService is disabled?

If it does, it's a regression and not a Canary blocker.

If it does not, it's not a regression.

Right now, it's labelled as both.

It occurs even when NetworkService is off.
The criteria makes sense. Let me remove Proj-Servicification-Canary.

Thanks. I think we should raise priority of this regression as it's happening in Stable.

jcivelli: Can we revert https://crrev.com/7cf9f94ce0b49c22dfed90bc685514416c308e87 or is there a simple fix possible in time for 69, or hopefully 68?

+Privacy labels.

shimazu@ has a patch.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da94c7cac55d720aa38acab1187c8db05fe6da76

commit da94c7cac55d720aa38acab1187c8db05fe6da76
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Mon Jul 09 08:06:38 2018

Pass RendererPreferences to WorkerFetchContext for DedicatedWorkers

This CL is to pass the RendererPreferences from RenderViewImpl to WorkerFetchContext
to reflect the configuration. This only works for DedicatedWorkers since we
don't have regular RenderViewImpl for SharedWorkers and ServiceWorkers.

This also adds browser tests for each case. Currently SharedWorker and
ServiceWorker one are disabled.

Bug:  853085 
Change-Id: I128804c802d75b30ee770fdb938878621ff2172a
Reviewed-on: https://chromium-review.googlesource.com/1124202
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573242}
[modify] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/browser/do_not_track_browsertest.cc
[modify] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/renderer/service_worker/worker_fetch_context_impl.cc
[modify] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/renderer/service_worker/worker_fetch_context_impl.h
[modify] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[add] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/test/data/service_worker/create_service_worker.html
[add] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/test/data/service_worker/fetch_from_service_worker.html
[add] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/test/data/service_worker/fetch_from_service_worker.js
[add] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/test/data/workers/create_shared_worker.html
[add] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/test/data/workers/create_worker.html
[add] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/test/data/workers/fetch_from_shared_worker.html
[add] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/test/data/workers/fetch_from_shared_worker.js
[add] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/test/data/workers/fetch_from_worker.html
[add] https://crrev.com/da94c7cac55d720aa38acab1187c8db05fe6da76/content/test/data/workers/fetch_from_worker.js

As far as I know, the remaining work here is:
1. Propagate RendererPreferences from the parent dedicated worker to nested
   dedicated workers.
2. Propagate RendererPreferences from the browser to service worker and shared
   workers.
3. Ensure RendererPreferences are respected when a page is controlled by a
   service worker that falls back to network, or the page is controlled by a
  no-fetch service worker.

bashi@ has a patch for 2.

I'd like to request merge c#15 to beta before it goes to stable.
Honestly I want to merge fixes fpr service workers (crrev.com/c/1130967) and shared workers (crrev.com/c/1135107), but those haven't landed yet, so let me request a merge of the fix for dedicated workers first.

This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please mark OS

Sure, sdded OS tags.

Seems like this has been present since M66 and M67. How safe is this merge, and what are the implications if we wait until M69 to take this?

Thanks. DNT header is for preserving privacy which is opted-in by users manually, so I wanted to put fixes in asap.
However, given that all fixes are not ready (we need to fix shared worker/service worker cases too) and the bug has already been present since M67, I agree that we can wait.
I'll ask you again to request merge all other fixes to *M69* once they are ready.

Re c#16:

#1: in the comment has already been fixed. WebWorkerFetchContextImpl::CloneForNestedWorker() propagates its |renderer_preferences_| to the cloned fetch context. We may be able to add more tests for that.
https://cs.chromium.org/chromium/src/content/renderer/loader/web_worker_fetch_context_impl.cc?sq=package:chromium&g=0&l=202
#2: bashi@ is now working on weird bot failures on Android. Once it's fixed, we can send patches for shared worker and service workers.
#3: I'm adding a couple of browser tests to ensure it works (crrev.com/c/1139458).

Additionally, I found #4: we might need to fix requests for service worker/shared worker's script. I've not investigated that yet.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4632987c6c0d2cd18b119b6638c0658a2739395f

commit 4632987c6c0d2cd18b119b6638c0658a2739395f
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Tue Jul 17 09:43:40 2018

service worker: Populate RendererPreferences via ContentBrowserClient

When we load subresorces from the main thread and dedicated workers
we use RenderViewImpl's RendererPreferences to check DNT header
should be set or not. Since RenderViewImpl may not be available
for service workers we need another way to pass RendererPreferences
from browser to renderer. This CL adds a method to ContentBrowserClient
to get RendererPreferences from chrome/ to content/, and piggybacks
the preferences in EmbeddedWorkerStartParams to populate it from
browser to renderer.

Bug:  853085 
Change-Id: Ibdd6bac46bbf0e27c02866f496482041e8789138
Reviewed-on: https://chromium-review.googlesource.com/1130967
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575592}
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/browser/do_not_track_browsertest.cc
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/public/browser/content_browser_client.h
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/renderer/loader/web_worker_fetch_context_impl.h
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/renderer/service_worker/service_worker_fetch_context_impl.cc
[modify] https://crrev.com/4632987c6c0d2cd18b119b6638c0658a2739395f/content/renderer/service_worker/service_worker_fetch_context_impl.h

Sounds good - let's target all fixes for M69. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a734fb249347d237070c0aacc420899cf422d99

commit 7a734fb249347d237070c0aacc420899cf422d99
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Thu Jul 19 03:43:39 2018

Propagate RendererPreferences to SharedWorker

When starting a new shared worker, RendererPreferences is passed from the
browser to the renderer. This preference is used to reflect DNT header and
referrer for requests from shared workers.

Bug:  853085 
Change-Id: Ie369a3ec513ffd16ba8a3f4b6a28061e6e1e83c0
Reviewed-on: https://chromium-review.googlesource.com/1135107
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576354}
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/browser/do_not_track_browsertest.cc
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/browser/shared_worker/mock_shared_worker.cc
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/browser/shared_worker/mock_shared_worker.h
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/browser/shared_worker/shared_worker_host_unittest.cc
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/7a734fb249347d237070c0aacc420899cf422d99/content/renderer/shared_worker/shared_worker_factory_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e82c76322c94ffd3a13b9641b3b4d61b635c965

commit 6e82c76322c94ffd3a13b9641b3b4d61b635c965
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Fri Jul 20 03:09:30 2018

Add browser tests for DNT via a service worker falling back to network

Adding tests to check if DNT header is perserved when a page is controlled by a
service worker but requests fall back to the network.

Bug:  853085 
Change-Id: I9beeda397d4fbdef13aee11e36af3efaaec142f1
Reviewed-on: https://chromium-review.googlesource.com/1139458
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576767}
[modify] https://crrev.com/6e82c76322c94ffd3a13b9641b3b4d61b635c965/content/browser/do_not_track_browsertest.cc
[modify] https://crrev.com/6e82c76322c94ffd3a13b9641b3b4d61b635c965/content/test/data/service_worker/create_service_worker.html
[add] https://crrev.com/6e82c76322c94ffd3a13b9641b3b4d61b635c965/content/test/data/service_worker/empty.js
[add] https://crrev.com/6e82c76322c94ffd3a13b9641b3b4d61b635c965/content/test/data/service_worker/fetch_from_page.html

I expect that a request for shared worker script will have DNT once PlzWorker finished (we can read the preference in the browser process). The last one is service worker scripts, and I think we can do something when service worker startup goes off main thread. 
Let me de-prioritize this and release this issue for now since most of cases are working well for now.

Just to be sure, we've fixed this for requests from nested workers too, right?

+jam: FYI, as it looks like this regressed in https://chromium.googlesource.com/chromium/src/+/7cf9f94ce0b49c22dfed90bc685514416c308e87 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a49dbc584bb1e0a8242e2436270117daea70605

commit 3a49dbc584bb1e0a8242e2436270117daea70605
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Mon Jul 30 02:21:04 2018

Test for DNT from a controlled page, fetch re-issued from service worker

The service worker has a simple fetch handler which returns a response fetched
from the service worker.

Bug:  853085 
Change-Id: I605a495da3657017e0c43cef63499a523b225f69
Reviewed-on: https://chromium-review.googlesource.com/1152757
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578966}
[modify] https://crrev.com/3a49dbc584bb1e0a8242e2436270117daea70605/content/browser/do_not_track_browsertest.cc

Let me put me back to the owner. I'm working on the remaining issue: service worker/shared worker scripts.

I'm landing the final patch to fix the case #4 in c#24: crrev.com/c/1154782.
I'd like to request merge to beta after a few days after it hits on canary.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/408a3b3149e9562edad3dc60214485651f7debef

commit 408a3b3149e9562edad3dc60214485651f7debef
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Aug 01 10:45:03 2018

Add DNT header for service worker and shared worker scripts

These are loaded through WorkerShadowPage, and this CL to add a code to check
the preferences and add the header in there.

Bug:  853085 
Change-Id: I080e3fa4cb175763b17dca127907750c51eef966
Reviewed-on: https://chromium-review.googlesource.com/1154782
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579752}
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/content/browser/do_not_track_browsertest.cc
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/content/public/common/renderer_preferences.h
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/common/BUILD.gn
[add] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/common/privacy_preferences.cc
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/public/common/BUILD.gn
[add] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/public/common/privacy_preferences.h
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/public/web/web_embedded_worker_start_data.h
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/public/web/web_shared_worker.h
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/renderer/core/exported/web_shared_worker_impl.h
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/renderer/core/exported/worker_shadow_page.cc
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/renderer/core/exported/worker_shadow_page.h
[modify] https://crrev.com/408a3b3149e9562edad3dc60214485651f7debef/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1655714809a20d064fa523f6e3a50d5e119f5021

commit 1655714809a20d064fa523f6e3a50d5e119f5021
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Aug 07 09:00:45 2018

Check if DNT header is set on browser_test by using /echoheader?DNT

Previously ChromeDoNotTrackTest only tested updates in RendererPreference
instead of issuing actual network request. This CL is to change the test to send
a request to check if the header is sent with respecting to the preference.

Bug:  853085 
Change-Id: I62d7eb88b3fea14db68baf5a23d1c44b4e8ab8db
Reviewed-on: https://chromium-review.googlesource.com/1164862
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581173}
[modify] https://crrev.com/1655714809a20d064fa523f6e3a50d5e119f5021/chrome/browser/chrome_do_not_track_browsertest.cc

Let me request merging c#35 to M69.

This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This is regressed in M67. And we're only taking truly critical and safe merges in for M69. Could you pls justify c#35 merge to M69?

c#35 fixes a bug around privacy related header so I'd like to fix this issue asap. All cases will be fixed in M69 once we merge c#35.
I think it'll be safe enough since it's propagates the settings in the same way with previous patches which has already landed in M69.

Approving merge to M69 branch for cl listed at #35 based on comment #40 and per offline chat with shimazu@, change has browser tests coverage and safe to merge. Please merge now, Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a136e23c5915d2b9a8cec254833b6b56309b387b

commit a136e23c5915d2b9a8cec254833b6b56309b387b
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Aug 08 00:48:57 2018

[M69] Add DNT header for service worker and shared worker scripts

These are loaded through WorkerShadowPage, and this CL to add a code to check
the preferences and add the header in there.

TBR=shimazu@chromium.org

(cherry picked from commit 408a3b3149e9562edad3dc60214485651f7debef)

Bug:  853085 
Change-Id: I080e3fa4cb175763b17dca127907750c51eef966
Reviewed-on: https://chromium-review.googlesource.com/1154782
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#579752}
Reviewed-on: https://chromium-review.googlesource.com/1166270
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#482}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/content/browser/do_not_track_browsertest.cc
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/content/public/common/renderer_preferences.h
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/common/BUILD.gn
[add] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/common/privacy_preferences.cc
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/public/common/BUILD.gn
[add] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/public/common/privacy_preferences.h
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/public/web/web_embedded_worker_start_data.h
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/public/web/web_shared_worker.h
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/renderer/core/exported/web_shared_worker_impl.h
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/renderer/core/exported/worker_shadow_page.cc
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/renderer/core/exported/worker_shadow_page.h
[modify] https://crrev.com/a136e23c5915d2b9a8cec254833b6b56309b387b/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/068abd923b0ccadeff8de98cdc8700b57622be9d

commit 068abd923b0ccadeff8de98cdc8700b57622be9d
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Thu Aug 09 07:50:23 2018

Add browser tests of updating DNT settings for workers

Changes in the preferences should be reflected immediately. This CL adds tests
on dedicated workers, shared workers, and service workers.

Bug:  853085 
Change-Id: I8ea97eb45a02ecc81912c93a72127d4931148aa8
Reviewed-on: https://chromium-review.googlesource.com/1167062
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581822}
[modify] https://crrev.com/068abd923b0ccadeff8de98cdc8700b57622be9d/chrome/browser/chrome_do_not_track_browsertest.cc
[add] https://crrev.com/068abd923b0ccadeff8de98cdc8700b57622be9d/chrome/test/data/workers/fetch_from_service_worker.html
[add] https://crrev.com/068abd923b0ccadeff8de98cdc8700b57622be9d/chrome/test/data/workers/fetch_from_service_worker.js
[add] https://crrev.com/068abd923b0ccadeff8de98cdc8700b57622be9d/chrome/test/data/workers/fetch_from_shared_worker.html
[add] https://crrev.com/068abd923b0ccadeff8de98cdc8700b57622be9d/chrome/test/data/workers/fetch_from_shared_worker.js
[add] https://crrev.com/068abd923b0ccadeff8de98cdc8700b57622be9d/chrome/test/data/workers/fetch_from_worker.html
[add] https://crrev.com/068abd923b0ccadeff8de98cdc8700b57622be9d/chrome/test/data/workers/fetch_from_worker.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f

commit b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Sat Aug 11 09:25:01 2018

Propagate update on RendererPreferences to ServiceWorkerFetchContextImpl

Each FetchContexts needs to be notified it's update. This introduces a new Mojo
interface (mojom::RendererPreferenceWatcher) to observe changes in the
preferences.

Bug:  853085 
Change-Id: I3985c0ee363e073099d1a3ac85bf210f5bbce537
Reviewed-on: https://chromium-review.googlesource.com/1164151
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582445}
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/chrome/browser/chrome_do_not_track_browsertest.cc
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/chrome/browser/ui/prefs/pref_watcher.cc
[add] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/chrome/browser/ui/prefs/pref_watcher.h
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/common/native_types.mojom
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/common/native_types.typemap
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/common/render_message_filter.mojom
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/common/renderer.mojom
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/common/view_messages.h
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/public/browser/content_browser_client.h
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/public/common/BUILD.gn
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/public/common/common_param_traits_macros.h
[add] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/public/common/renderer_preference_watcher.mojom
[add] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/public/common/renderer_preferences.mojom
[add] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/public/common/renderer_preferences.typemap
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/public/common/typemaps.gni
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/renderer/service_worker/service_worker_fetch_context_impl.cc
[modify] https://crrev.com/b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f/content/renderer/service_worker/service_worker_fetch_context_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1df3739e6d058fb277c50c289adf5734577e70b

commit c1df3739e6d058fb277c50c289adf5734577e70b
Author: Peter Kasting <pkasting@chromium.org>
Date: Sat Aug 11 16:38:59 2018

Revert "Propagate update on RendererPreferences to ServiceWorkerFetchContextImpl"

This reverts commit b6cde39f3618f24c1a0b40419e3acd83fe0a4f0f.

Reason for revert: Caused flaky compile failures, e.g. https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/54711 , https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/192 , https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/1165

Original change's description:
> Propagate update on RendererPreferences to ServiceWorkerFetchContextImpl
> 
> Each FetchContexts needs to be notified it's update. This introduces a new Mojo
> interface (mojom::RendererPreferenceWatcher) to observe changes in the
> preferences.
> 
> Bug:  853085 
> Change-Id: I3985c0ee363e073099d1a3ac85bf210f5bbce537
> Reviewed-on: https://chromium-review.googlesource.com/1164151
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582445}

TBR=avi@chromium.org,kinuko@chromium.org,shimazu@chromium.org

Change-Id: Idda3a12439b55f00269ba3a3c0ea129a44c2fcf6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  853085 
Reviewed-on: https://chromium-review.googlesource.com/1171716
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582451}
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/chrome/browser/chrome_do_not_track_browsertest.cc
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/13044802db6b6a9e3689e40d30bccb22f8930124/chrome/browser/ui/prefs/pref_watcher.cc
[delete] https://crrev.com/13044802db6b6a9e3689e40d30bccb22f8930124/chrome/browser/ui/prefs/pref_watcher.h
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/common/native_types.mojom
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/common/native_types.typemap
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/common/render_message_filter.mojom
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/common/renderer.mojom
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/common/view_messages.h
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/public/browser/content_browser_client.h
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/public/common/BUILD.gn
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/public/common/common_param_traits_macros.h
[delete] https://crrev.com/13044802db6b6a9e3689e40d30bccb22f8930124/content/public/common/renderer_preference_watcher.mojom
[delete] https://crrev.com/13044802db6b6a9e3689e40d30bccb22f8930124/content/public/common/renderer_preferences.mojom
[delete] https://crrev.com/13044802db6b6a9e3689e40d30bccb22f8930124/content/public/common/renderer_preferences.typemap
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/public/common/typemaps.gni
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/renderer/service_worker/service_worker_fetch_context_impl.cc
[modify] https://crrev.com/c1df3739e6d058fb277c50c289adf5734577e70b/content/renderer/service_worker/service_worker_fetch_context_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c750293ac72f49b2076d49eb5a5425e9c3f09fb8

commit c750293ac72f49b2076d49eb5a5425e9c3f09fb8
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Aug 15 02:12:56 2018

Reland "Propagate update on RendererPreferences to ServiceWorkerFetchContextImpl"

This reverts commit c1df3739e6d058fb277c50c289adf5734577e70b.

Original description:
> Each FetchContexts needs to be notified it's update. This introduces a new Mojo
> interface (mojom::RendererPreferenceWatcher) to observe changes in the
> preferences.

TBR=lazyboy@chromium.org avi@chromium.org

Bug:  853085 
Change-Id: I850dbba70812013e2495670229a00e8e94f1a597
Reviewed-on: https://chromium-review.googlesource.com/1174203
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583131}
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/chrome/browser/chrome_do_not_track_browsertest.cc
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/chrome/browser/ui/prefs/pref_watcher.cc
[add] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/chrome/browser/ui/prefs/pref_watcher.h
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/chrome/browser/ui/prefs/prefs_tab_helper.cc
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/common/native_types.mojom
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/common/native_types.typemap
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/common/render_message_filter.mojom
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/common/renderer.mojom
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/common/view_messages.h
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/public/browser/content_browser_client.h
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/public/common/BUILD.gn
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/public/common/common_param_traits_macros.h
[add] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/public/common/renderer_preference_watcher.mojom
[add] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/public/common/renderer_preferences.mojom
[add] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/public/common/renderer_preferences.typemap
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/public/common/typemaps.gni
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/renderer/service_worker/service_worker_fetch_context_impl.cc
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/content/renderer/service_worker/service_worker_fetch_context_impl.h
[modify] https://crrev.com/c750293ac72f49b2076d49eb5a5425e9c3f09fb8/extensions/common/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047

commit c3c730ed7b790a5c8bdda1cc4c6d033458cbc047
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Aug 15 09:51:11 2018

Propagate updates in RendererPreferences to dedicated workers

This is to reflect updates of RendererPreferences arrived at RenderViewImpl to
WebWorkerFetchContextImpls. In order to propagate settings to all nested
workers, this CL uses mojom::RendererPreferenceWatcher. RenderViewImpl holds
mojom::RendererPreferenceWatcherPtr connected to each worker created on the
page's context, and each worker has mojom::RendererPreferenceWatcherPtr
connected to each child worker created on the worker's context. Once
new preference is arrived at RenderViewImpl::OnSetRenderPrefs(), the new
preferences will be propagated by passing through the pipes one by one.

TBR=avi@chromium.org

Bug:  853085 
Change-Id: I158fac878f984c9e6e69e45862c5d9209fd6927e
Reviewed-on: https://chromium-review.googlesource.com/1170673
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583208}
[modify] https://crrev.com/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047/chrome/browser/chrome_do_not_track_browsertest.cc
[add] https://crrev.com/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047/chrome/test/data/workers/fetch_from_nested_worker.js
[modify] https://crrev.com/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047/chrome/test/data/workers/fetch_from_worker.html
[modify] https://crrev.com/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047/content/renderer/loader/web_worker_fetch_context_impl.cc
[modify] https://crrev.com/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047/content/renderer/loader/web_worker_fetch_context_impl.h
[modify] https://crrev.com/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047/content/renderer/render_view_impl.cc
[modify] https://crrev.com/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047/content/renderer/render_view_impl.h
[modify] https://crrev.com/c3c730ed7b790a5c8bdda1cc4c6d033458cbc047/content/renderer/shared_worker/embedded_shared_worker_stub.cc

This is the final CL to fix shared worker case: https://chromium-review.googlesource.com/c/chromium/src/+/1175584

All fixes have landed now.
I could manually confirm the tests with --enable-features=NetworkService works well (and I think it runs on network_service_browser_tests).

In short, we fixed
- a bug in sending DNT header in M69. The setting is reflected when the worker is launched up, but updating the setting won't affect to existing workers.
- a bug in updating DNT header in M70. Changes in the setting are reflected soon.