New issue
Advanced search Search tips

Issue 853079 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

"SelectFileDialogImplGtkTest.Select*Folder" are flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 15 2018

Issue description

"SelectFileDialogImplGtkTest.SelectFolder" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihTZWxlY3RGaWxlRGlhbG9nSW1wbEd0a1Rlc3QuU2VsZWN0Rm9sZGVyDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: Pri-2

Comment 2 by treib@chromium.org, Jun 18 2018

 Issue 852930  has been merged into this issue.

Comment 3 by treib@chromium.org, Jun 18 2018

Summary: "SelectFileDialogImplGtkTest.Select*Folder" are flaky (was: "SelectFileDialogImplGtkTest.SelectFolder" is flaky)
SelectExistingFolder, SelectFolder, SelectUploadFolder are all flaky:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=SelectFileDialogImplGtkTest

Comment 4 by treib@chromium.org, Jun 18 2018

Labels: OS-Linux

Comment 5 by treib@chromium.org, Jun 18 2018

Cc: est...@chromium.org
Owner: thomasanderson@chromium.org
Status: Assigned (was: Untriaged)
Nothing useful in the failure logs, the tests just timeout without any output.

Over to owners; I'll go ahead and disable the tests.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5adc8736b696f671a5ea21ed4337996b874180f

commit a5adc8736b696f671a5ea21ed4337996b874180f
Author: Marc Treib <treib@chromium.org>
Date: Mon Jun 18 11:09:55 2018

Disable flaky SelectFileDialogImplGtkTest.Select*Folder

TBR=thomasanderson@chromium.org
NOTRY=true

Bug: 853079
Change-Id: I982e23595e1ca923c6ebbc09470b74e7b41ab20f
Reviewed-on: https://chromium-review.googlesource.com/1104171
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567968}
[modify] https://crrev.com/a5adc8736b696f671a5ea21ed4337996b874180f/chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk_unittest.cc

Comment 7 by treib@chromium.org, Jun 18 2018

Labels: -Sheriff-Chromium Test-Disabled SelectFileDialogImplGtkTest.SelectExistingFolder SelectFileDialogImplGtkTest.SelectUploadFolder SelectFileDialogImplGtkTest.SelectFolder
Owner: aee@chromium.org

Sign in to add a comment