New issue
Advanced search Search tips

Issue 853064 link

Starred by 2 users
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Support IPv6 addresses in match patterns

Project Member Reported by rdevlin....@chromium.org, Jun 15 2018 
Match patterns [1] support IPv4 addresses.  They should also support IPv6.  This is most important for the underlying URLPattern structure, since this support will be necessary to support origin permissions for these addresses.  This will be needed for both activeTab support and runtime host permissions support.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c008bf657dbc01fadc4ff1ea3df21f9cf237569a

commit c008bf657dbc01fadc4ff1ea3df21f9cf237569a
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Jun 19 01:17:19 2018

[Extensions] Support IPv6 in URLPatterns

Add IPv6 support to match patterns (URLPatterns). This is most necessary
for implementing activeTab support on IPv6 addresses, and will also be
needed for runtime host permissions.

Bug:  853064 
Change-Id: I0ac1980af679476c17112137575d37ad77490dcc
Reviewed-on: https://chromium-review.googlesource.com/1102118
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568278}
[modify] https://crrev.com/c008bf657dbc01fadc4ff1ea3df21f9cf237569a/extensions/common/url_pattern.cc
[modify] https://crrev.com/c008bf657dbc01fadc4ff1ea3df21f9cf237569a/extensions/common/url_pattern.h
[modify] https://crrev.com/c008bf657dbc01fadc4ff1ea3df21f9cf237569a/extensions/common/url_pattern_set_unittest.cc
[modify] https://crrev.com/c008bf657dbc01fadc4ff1ea3df21f9cf237569a/extensions/common/url_pattern_unittest.cc

Comment 2 by rdevlin....@chromium.org, Jun 29 2018

Status: Fixed (was: Started)
►

Sign in to add a comment