New issue
Advanced search Search tips

Issue 853062 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Float-cast-overflow in blink::CSSLonghand::Cursor::ParseSingleValue

Project Member Reported by ClusterFuzz, Jun 15 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6337254549880832

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::CSSLonghand::Cursor::ParseSingleValue
  blink::CSSPropertyParserHelpers::ParseLonghand
  blink::CSSPropertyParser::ParseValueStart
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6337254549880832

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 15 2018

Components: Blink>CSS
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 15 2018

Labels: Test-Predator-Auto-Owner
Owner: andruud@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/ec18bd7222f763c7f1d1cb6265273e52259a6549 (Move custom style builders into CSSProperty classes.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef397144079b11aa66b88a7a60dd9984991c0cc0

commit ef397144079b11aa66b88a7a60dd9984991c0cc0
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Fri Jun 15 13:25:00 2018

Avoid float-cast-overflow in Cursor::ParseSingleValue.

R=futhark@chromium.org

Bug:  853062 
Change-Id: I3cc1727fb5696b53810589994d864dcd579ddfc9
Reviewed-on: https://chromium-review.googlesource.com/1102325
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567621}
[modify] https://crrev.com/ef397144079b11aa66b88a7a60dd9984991c0cc0/third_party/WebKit/LayoutTests/fast/css/cursor-hotspot-computed-style.html
[modify] https://crrev.com/ef397144079b11aa66b88a7a60dd9984991c0cc0/third_party/blink/renderer/core/css/properties/longhands/cursor_custom.cc

Project Member

Comment 5 by ClusterFuzz, Jun 16 2018

ClusterFuzz has detected this issue as fixed in range 567620:567622.

Detailed report: https://clusterfuzz.com/testcase?key=6337254549880832

Fuzzer: inferno_twister
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Float-cast-overflow
Crash Address: 
Crash State:
  blink::CSSLonghand::Cursor::ParseSingleValue
  blink::CSSPropertyParserHelpers::ParseLonghand
  blink::CSSPropertyParser::ParseValueStart
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=551565:563900
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=567620:567622

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6337254549880832

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jun 16 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6337254549880832 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment