New issue
Advanced search Search tips

Issue 853058 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Reinitialize BackgroundFetchContext with previous fetches after browser restart

Project Member Reported by rayankans@chromium.org, Jun 15 2018

Issue description

Now that fetches are persisted, BackgroundFetchContext should re-initialize the JobControllers and resume fetches.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d49275218e286c791d68f6d31556b67f4a83bca

commit 3d49275218e286c791d68f6d31556b67f4a83bca
Author: Rayan Kanso <rayankans@chromium.org>
Date: Thu Jul 05 15:05:42 2018

[Background Fetch] Create DatabaseTask for context initialization.

Adds a new DatabaseTask to be used by BackgroundFetchContext upon
initialization. Gets all the required information to resume fetches from
the previous session.

TBR=avi@chromium.org

Bug:  853058 
Change-Id: Ic31aa0d7794427d8d63ed46ed71c100025a3ccae
Reviewed-on: https://chromium-review.googlesource.com/1101683
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572794}
[modify] https://crrev.com/3d49275218e286c791d68f6d31556b67f4a83bca/content/browser/BUILD.gn
[modify] https://crrev.com/3d49275218e286c791d68f6d31556b67f4a83bca/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/3d49275218e286c791d68f6d31556b67f4a83bca/content/browser/background_fetch/background_fetch_data_manager.h
[modify] https://crrev.com/3d49275218e286c791d68f6d31556b67f4a83bca/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[add] https://crrev.com/3d49275218e286c791d68f6d31556b67f4a83bca/content/browser/background_fetch/storage/get_initialization_data_task.cc
[add] https://crrev.com/3d49275218e286c791d68f6d31556b67f4a83bca/content/browser/background_fetch/storage/get_initialization_data_task.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ce058b26947a64f81a2d51c1249298edac06d2

commit b5ce058b26947a64f81a2d51c1249298edac06d2
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri Jul 06 16:03:19 2018

[Background Fetch] Initialize context with pending fetches.

Create JobControllers with the incomplete fetches on startup.

Bug:  853058 
Change-Id: Iaaed4d4cab5cf86e7cc89fb00ce5eceb6778ce5f
Reviewed-on: https://chromium-review.googlesource.com/1103157
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572981}
[modify] https://crrev.com/b5ce058b26947a64f81a2d51c1249298edac06d2/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/b5ce058b26947a64f81a2d51c1249298edac06d2/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/b5ce058b26947a64f81a2d51c1249298edac06d2/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/b5ce058b26947a64f81a2d51c1249298edac06d2/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/b5ce058b26947a64f81a2d51c1249298edac06d2/content/browser/background_fetch/background_fetch_data_manager.h
[modify] https://crrev.com/b5ce058b26947a64f81a2d51c1249298edac06d2/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/b5ce058b26947a64f81a2d51c1249298edac06d2/content/browser/background_fetch/background_fetch_service_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment