New issue
Advanced search Search tips

Issue 853057 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ExtensionApiTest.UpdateWindowSizeExitsFullscreen fails on Linux with Refresh enabled

Project Member Reported by bsep@chromium.org, Jun 15 2018

Issue description

Passes on other platforms so I think we can delay investigation and disable the test for now.
 
Labels: -Pri-3 ReleaseBlock-Beta Pri-2
I don't want this to be forgotten so adding RB and priority.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2479064245318b12bdc09e5aaa12436955d32529

commit 2479064245318b12bdc09e5aaa12436955d32529
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Jun 15 19:15:23 2018

Skip ExtensionApiTest.UpdateWindowSizeExitsFullscreen on Linux/Refresh.

Temporarily disabling the test so we can enable the Refresh feature by
default. The test passes on other platforms.

Bug:  853057 
Change-Id: I95c330f0531e58a94fda4813bc4bffd3fa8bbedf
Reviewed-on: https://chromium-review.googlesource.com/1102126
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567758}
[modify] https://crrev.com/2479064245318b12bdc09e5aaa12436955d32529/chrome/browser/extensions/extension_fullscreen_apitest.cc

Project Member

Comment 3 by sheriffbot@chromium.org, Jun 18 2018

Cc: benwells@chromium.org
This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by bsep@chromium.org, Jun 18 2018

Labels: Target-69

Comment 5 by gov...@chromium.org, Jun 18 2018

M69 branch is coming soon on July 19th, Your bug is marked as ReleaseBlock-Beta for M69. Please try to land the fix ASAP to trunk in order to prevent many merges going after M69 branch. This will also help us to branch M69 from high quality trunk. Thank you.


Project Member

Comment 6 by sheriffbot@chromium.org, Jun 21 2018

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 Pri-1
Owner: tbergquist@chromium.org
Status: Assigned (was: Available)
upgrading pri as it is release blocking

Comment 8 by bsep@chromium.org, Jun 21 2018

Owner: bsep@chromium.org
I'm looking at this separately already.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/302009c773b24acdda0342bcf54377de19f65038

commit 302009c773b24acdda0342bcf54377de19f65038
Author: Bret Sepulveda <bsep@chromium.org>
Date: Sat Jun 23 00:30:28 2018

Fix tests programmatically setting the window size under Refresh.

There were several tests that were failing because they were attempting
to set the window to a particular size, and the minimum size of a window
increases to more than that size when Refresh is enabled.

TBR=gab@chromium.org

Bug:  846410 ,  853057 ,  853044 
Change-Id: Idad9ae2db2d0eacfc0432d9b5bb0ebe6734d47a4
Reviewed-on: https://chromium-review.googlesource.com/1111106
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569857}
[modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/browser/extensions/extension_fullscreen_apitest.cc
[modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/browser/prefs/pref_service_browsertest.cc
[modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/test/data/extensions/api_test/window_update/sizing/test.js
[modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/test/data/profiles/window_placement/Default/Preferences

Comment 10 by bsep@chromium.org, Jun 23 2018

Status: Fixed (was: Assigned)

Sign in to add a comment