Using the spacebar to scroll stops working after clicking on an iframe
Reported by
russell....@gmail.com,
Jun 15 2018
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36 Example URL: https://www.amazon.com/Buyout-America-Private-Equity-Credit/dp/1591842859 Steps to reproduce the problem: 1. Load a page with an iframe (e.g., https://www.amazon.com/Buyout-America-Private-Equity-Credit/dp/1591842859) 2. Click inside the iframe to give it focus (for the URL above, click in the book description area that starts with "An authoritative exposé") 3. Press the spacebar to scroll the page. What is the expected behavior? The page should scroll down. What went wrong? Nothing happens. Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? Yes Chrome version: 67.0.3396.87 Channel: stable OS Version: OS X 10.13.4 Flash Version: This is related to https://bugs.chromium.org/p/chromium/issues/detail?id=852932, but it happens even when SitePerProcess is disabled, and it happens in some cases (like the amazon example above) where the arrow keys work fine, but spacebar in particular does not.
,
Jun 15 2018
Able to reproduce the issue on reported chrome version 67.0.3396.87 and on latest chrome 69.0.3460.0 using Mac 10.13.5, Ubuntu 14.04 and Windows 10 . Same behavior is seen on M60(60.0.3112.113) hence considering it as non-regression and marking it as Untriaged. Thanks!
,
Jun 15 2018
Just confirming that this appears to be a different issue from issue 852932 , and that it reproes even without site isolation (the iframe in the repro is same-site) on Linux ToT. Adding a few more folks from the other bug. bokan@, would you mind triaging this further?
,
Jun 15 2018
It was mentioned that converting keyboard scrolling to use gesture events in issue 125223 will solve issue 852932 . Will that work help solve this issue as well?
,
Jun 15 2018
|KeyboardEventManager::DefaultSpaceEventHandler| is just calling |LogicalScroll| instead of |BubblingScroll| as is done with the arrow keys. Simply changing the call to |BubblingScroll| seems to allow the spacebar scroll to bubble from a same-site iframe.
,
Jun 15 2018
It can't be BubblingScroll because LogicalScroll is needed to handle writing modes correctly. Space should scroll "forward" which depends on the scroller's writing mode. Doubt the fix is too much more complicated though if BubblingScroll works. Sahel, ptal when you have some time (but since it's a non regression it's not urgent). |
||||
►
Sign in to add a comment |
||||
Comment 1 by viswa.karala@chromium.org
, Jun 15 2018