Libuuid1 was added to install-build-deps.sh in [1]. It is necessary for updating fontconfig in CL [2]. install-build-deps.sh should be rerun on the bot images, and/or libuuid1 should be added to the puppet configs. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1102009 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1095538
+johnw do you know who would be a good owner for this?
Sorry for the delay.
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/47a182206c6d3d9d162459718ff841ce1c96a972 commit 47a182206c6d3d9d162459718ff841ce1c96a972 Author: Elliott Friedman <friedman@google.com> Date: Fri Jun 15 23:49:25 2018
libuuid1 is installing on the bots now. I'll leave this open for now and remove the change next week. Please don't close this bug.
Thanks, friedman. Is it now safe to land this CL, which adds a dep on libuuid1? https://chromium-review.googlesource.com/c/chromium/src/+/1095538
Wait until "Fri Jun 15 23:49:25 2018" + 1 hour
I don't think I can safely remove the puppet change until the default image is newer than the install-build-deps change, so this is fixed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c91664fce2e753a65b04107ad24c7422691cf9d commit 0c91664fce2e753a65b04107ad24c7422691cf9d Author: Tom Anderson <thomasanderson@chromium.org> Date: Mon Jun 18 23:13:53 2018 Reland "Update fontconfig to 6cc99d6a" This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ). Original change's description: > Update fontconfig to 6cc99d6a > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to > fix a use-after-free. > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > dependency since we statically link fontconfig. > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > BUG= 831146 ,822737, 787020 , 829890 ,847323 > TBR=thestig,dnicoara > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec > Reviewed-on: https://chromium-review.googlesource.com/1095538 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567445} TBR=thestig,dnicoara Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869 Reviewed-on: https://chromium-review.googlesource.com/1104759 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#568221} [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/DEPS [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/base/test/fontconfig_util_linux.cc [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/debian/dist_package_versions.json [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/debian/update_dist_package_versions.py [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/rpm/dist_package_provides.json [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/chrome/installer/linux/rpm/update_package_provides.py [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/BUILD.gn [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/OWNERS [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/README.chromium [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/config.h [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/fc-case/fccase.h [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcalias.h [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcaliastail.h [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcftalias.h [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcftaliastail.h [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcobjshash.h [modify] https://crrev.com/0c91664fce2e753a65b04107ad24c7422691cf9d/third_party/fontconfig/include/src/fcstdint.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/812edd08bc908333c1c10205cbc5f52ef33c7dec commit 812edd08bc908333c1c10205cbc5f52ef33c7dec Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Jun 19 05:03:31 2018 Revert "Reland "Update fontconfig to 6cc99d6a"" This reverts commit 0c91664fce2e753a65b04107ad24c7422691cf9d. Reason for revert: Broke Linux Builder (dbg)(32) Still missing libuuid: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697 [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86) FAILED: v8_context_snapshot.bin python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory ./v8_context_snapshot_generator failed with exit code 127 Original change's description: > Reland "Update fontconfig to 6cc99d6a" > > This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c > > Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ). > > Original change's description: > > Update fontconfig to 6cc99d6a > > > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to > > fix a use-after-free. > > > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > > dependency since we statically link fontconfig. > > > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > > > BUG= 831146 ,822737, 787020 , 829890 ,847323 > > TBR=thestig,dnicoara > > > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec > > Reviewed-on: https://chromium-review.googlesource.com/1095538 > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#567445} > > TBR=thestig,dnicoara > > Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869 > Reviewed-on: https://chromium-review.googlesource.com/1104759 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568221} TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org Change-Id: Icd39638df79083776546d4283675c3e172bbefe4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 Reviewed-on: https://chromium-review.googlesource.com/1105539 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#568346} [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/DEPS [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/base/test/fontconfig_util_linux.cc [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/debian/dist_package_versions.json [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/debian/update_dist_package_versions.py [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/rpm/dist_package_provides.json [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/chrome/installer/linux/rpm/update_package_provides.py [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/BUILD.gn [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/OWNERS [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/README.chromium [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/config.h [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/fc-case/fccase.h [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcalias.h [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcaliastail.h [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcftalias.h [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcftaliastail.h [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcobjshash.h [modify] https://crrev.com/812edd08bc908333c1c10205cbc5f52ef33c7dec/third_party/fontconfig/include/src/fcstdint.h
Reopening because of the revert in c#10 which points out libuuid1 is still missing on some bots. friedman@ we also need libuuid1:i386 installed.
pinging friedman@ please see c#10
It's there. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20(dbg)(32)/83697 = build16-m1 chrome-bot@build16-m1:(Linux 14.04):~$ dpkg --list libuuid1 Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-=============================================-===========================-===========================-=============================================================================================== ii libuuid1:amd64 2.20.1-5.1ubuntu20.9 amd64 Universally Unique ID library Installing libuuid1:i386 as well...
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/9f53aa6dd9849e191cf090bd91775ae967f08c3b commit 9f53aa6dd9849e191cf090bd91775ae967f08c3b Author: Elliott Friedman <friedman@google.com> Date: Fri Jun 22 00:11:34 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0c1584a2fade0146b7cd3380abe42feda02ad7c commit a0c1584a2fade0146b7cd3380abe42feda02ad7c Author: Thomas Anderson <thomasanderson@chromium.org> Date: Fri Jun 22 22:01:06 2018 Reland "Reland "Update fontconfig to 6cc99d6a"" This reverts commit 812edd08bc908333c1c10205cbc5f52ef33c7dec. Reason for revert: libuuid1:i386 should now be installed on the bots ( bug 853048 ) Original change's description: > Revert "Reland "Update fontconfig to 6cc99d6a"" > > This reverts commit 0c91664fce2e753a65b04107ad24c7422691cf9d. > > Reason for revert: Broke Linux Builder (dbg)(32) > > Still missing libuuid: > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697 > > [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86) > FAILED: v8_context_snapshot.bin > python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin > ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory > ./v8_context_snapshot_generator failed with exit code 127 > > Original change's description: > > Reland "Update fontconfig to 6cc99d6a" > > > > This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c > > > > Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ). > > > > Original change's description: > > > Update fontconfig to 6cc99d6a > > > > > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to > > > fix a use-after-free. > > > > > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > > > dependency since we statically link fontconfig. > > > > > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c > > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > > > > > BUG= 831146 ,822737, 787020 , 829890 ,847323 > > > TBR=thestig,dnicoara > > > > > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec > > > Reviewed-on: https://chromium-review.googlesource.com/1095538 > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#567445} > > > > TBR=thestig,dnicoara > > > > Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 > > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869 > > Reviewed-on: https://chromium-review.googlesource.com/1104759 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#568221} > > TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org > > Change-Id: Icd39638df79083776546d4283675c3e172bbefe4 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 > Reviewed-on: https://chromium-review.googlesource.com/1105539 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568346} TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 Change-Id: I5fe29b3ff4ba7ec81498878124a39c70d5e9a8be Reviewed-on: https://chromium-review.googlesource.com/1112179 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Elliott Friedman <friedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569800} [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/DEPS [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/base/test/fontconfig_util_linux.cc [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/debian/dist_package_versions.json [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/debian/update_dist_package_versions.py [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/rpm/dist_package_provides.json [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/chrome/installer/linux/rpm/update_package_provides.py [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/BUILD.gn [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/OWNERS [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/README.chromium [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/config.h [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/fc-case/fccase.h [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcalias.h [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcaliastail.h [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcftalias.h [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcftaliastail.h [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcobjshash.h [modify] https://crrev.com/a0c1584a2fade0146b7cd3380abe42feda02ad7c/third_party/fontconfig/include/src/fcstdint.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee206c596acea3c453ec646c6002972793dbe62e commit ee206c596acea3c453ec646c6002972793dbe62e Author: Xiaoqian Dai <xdai@chromium.org> Date: Mon Jun 25 18:34:05 2018 Revert "Reland "Reland "Update fontconfig to 6cc99d6a""" This reverts commit a0c1584a2fade0146b7cd3380abe42feda02ad7c. Reason for revert: It broken Chrome PFQ, see crbug.com/856142 for more details. Original change's description: > Reland "Reland "Update fontconfig to 6cc99d6a"" > > This reverts commit 812edd08bc908333c1c10205cbc5f52ef33c7dec. > > Reason for revert: libuuid1:i386 should now be installed on the bots ( bug 853048 ) > > Original change's description: > > Revert "Reland "Update fontconfig to 6cc99d6a"" > > > > This reverts commit 0c91664fce2e753a65b04107ad24c7422691cf9d. > > > > Reason for revert: Broke Linux Builder (dbg)(32) > > > > Still missing libuuid: > > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697 > > > > [775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86) > > FAILED: v8_context_snapshot.bin > > python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin > > ././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory > > ./v8_context_snapshot_generator failed with exit code 127 > > > > Original change's description: > > > Reland "Update fontconfig to 6cc99d6a" > > > > > > This is a reland of e6db40d91d0bd2afeb39f78f6d22404c3525b63c > > > > > > Reason for reland: All bots should now have libuuid1 installed ( bug 853048 ). > > > > > > Original change's description: > > > > Update fontconfig to 6cc99d6a > > > > > > > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > > > > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > > > > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to > > > > fix a use-after-free. > > > > > > > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > > > > dependency since we statically link fontconfig. > > > > > > > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > > > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > > > > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > > > > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > > > > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c > > > > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > > > > > > > BUG= 831146 ,822737, 787020 , 829890 ,847323 > > > > TBR=thestig,dnicoara > > > > > > > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec > > > > Reviewed-on: https://chromium-review.googlesource.com/1095538 > > > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#567445} > > > > > > TBR=thestig,dnicoara > > > > > > Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 > > > Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869 > > > Reviewed-on: https://chromium-review.googlesource.com/1104759 > > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#568221} > > > > TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org > > > > Change-Id: Icd39638df79083776546d4283675c3e172bbefe4 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 > > Reviewed-on: https://chromium-review.googlesource.com/1105539 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#568346} > > TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 > Change-Id: I5fe29b3ff4ba7ec81498878124a39c70d5e9a8be > Reviewed-on: https://chromium-review.googlesource.com/1112179 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Elliott Friedman <friedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569800} TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,friedman@chromium.org,ortuno@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 Change-Id: Ic4c518680efb4480a9568829996f5ceebaf459e7 Reviewed-on: https://chromium-review.googlesource.com/1113840 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#570103} [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/DEPS [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/base/test/fontconfig_util_linux.cc [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/debian/dist_package_versions.json [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/debian/update_dist_package_versions.py [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/rpm/dist_package_provides.json [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/chrome/installer/linux/rpm/update_package_provides.py [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/BUILD.gn [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/OWNERS [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/README.chromium [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/config.h [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/fc-case/fccase.h [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcalias.h [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcaliastail.h [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcftalias.h [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcftaliastail.h [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcobjshash.h [modify] https://crrev.com/ee206c596acea3c453ec646c6002972793dbe62e/third_party/fontconfig/include/src/fcstdint.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81162e7432ecf59a861e5ba7be9f28b28b891dea commit 81162e7432ecf59a861e5ba7be9f28b28b891dea Author: Tom Anderson <thomasanderson@chromium.org> Date: Mon Jun 25 22:44:09 2018 "Reland "Update fontconfig to 6cc99d6a" Reason for reland: this CL includes a fallback for when the tests are run in an installed environment. Hopefully this should be sufficient to fix the CrOs bot breakage. Original change's description: > Update fontconfig to 6cc99d6a > > Changelog [1]. This is necessary to pick up [2] for fixing undefined-shift > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround, > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to > fix a use-after-free. > > Fontconfig also now requires libuuid as a dependency, so whitelist it as a > dependency since we statically link fontconfig. > > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914 > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74 > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde > > BUG= 831146 ,822737, 787020 , 829890 ,847323 > TBR=thestig,dnicoara > > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec > Reviewed-on: https://chromium-review.googlesource.com/1095538 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567445} TBR=thestig@chromium.org,dnicoara@chromium.org Bug: 831146 , 822737, 787020 , 829890 , 847323, 853048 , 856142 Change-Id: I74037fc1e7719ab61e6a5aff52ced8845482273b Reviewed-on: https://chromium-review.googlesource.com/1114078 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570210} [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/DEPS [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/base/test/fontconfig_util_linux.cc [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/debian/dist_package_versions.json [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/debian/update_dist_package_versions.py [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/rpm/dist_package_provides.json [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/chrome/installer/linux/rpm/update_package_provides.py [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/WebKit/LayoutTests/platform/linux/fast/text/unicode-fallback-font-expected.png [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/BUILD.gn [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/OWNERS [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/README.chromium [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/config.h [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/fc-case/fccase.h [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcalias.h [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcaliastail.h [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcftalias.h [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcftaliastail.h [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcobjshash.h [modify] https://crrev.com/81162e7432ecf59a861e5ba7be9f28b28b891dea/third_party/fontconfig/include/src/fcstdint.h
Comment 1 by thomasanderson@chromium.org
, Jun 15 2018