New issue
Advanced search Search tips

Issue 853044 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

PreservedWindowPlacement.Test fails on Linux with Refresh enabled

Project Member Reported by bsep@chromium.org, Jun 14 2018

Issue description

Passes on other platforms so I think we can delay investigation and disable the test for now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8ed12a58e4b35d2b7fc6d4b490711c7809a7011

commit c8ed12a58e4b35d2b7fc6d4b490711c7809a7011
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Jun 15 19:15:27 2018

Skip PreservedWindowPlacement.Test on Linux when Refresh is enabled.

Temporarily disabling the test so we can enable the feature by default.
The test passes on other platforms.

Bug:  853044 
Change-Id: I81e0e8cbba01263a28f1eb567f9ac168c715982e
Reviewed-on: https://chromium-review.googlesource.com/1102114
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567759}
[modify] https://crrev.com/c8ed12a58e4b35d2b7fc6d4b490711c7809a7011/chrome/browser/prefs/pref_service_browsertest.cc

Comment 2 by bsep@chromium.org, Jun 21 2018

Owner: bsep@chromium.org
Status: Assigned (was: Available)
I think I figured out what's wrong here.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/302009c773b24acdda0342bcf54377de19f65038

commit 302009c773b24acdda0342bcf54377de19f65038
Author: Bret Sepulveda <bsep@chromium.org>
Date: Sat Jun 23 00:30:28 2018

Fix tests programmatically setting the window size under Refresh.

There were several tests that were failing because they were attempting
to set the window to a particular size, and the minimum size of a window
increases to more than that size when Refresh is enabled.

TBR=gab@chromium.org

Bug:  846410 ,  853057 ,  853044 
Change-Id: Idad9ae2db2d0eacfc0432d9b5bb0ebe6734d47a4
Reviewed-on: https://chromium-review.googlesource.com/1111106
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569857}
[modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/browser/extensions/extension_fullscreen_apitest.cc
[modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/browser/prefs/pref_service_browsertest.cc
[modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/test/data/extensions/api_test/window_update/sizing/test.js
[modify] https://crrev.com/302009c773b24acdda0342bcf54377de19f65038/chrome/test/data/profiles/window_placement/Default/Preferences

Comment 4 by bsep@chromium.org, Jun 23 2018

Status: Fixed (was: Assigned)

Sign in to add a comment