migrate chromium.webkit and tryserver.blink to LUCI |
||||
Issue descriptionThis is a roll-up bug to track the work needed to either shut down or migrate all of the chromium.webkit and tryserver.blink builders to LUCI. Most of the builders on chromium.webkit should be shut down and we should just migrate the test suites onto the matching main waterfall builders. We still need the tryserver.blink builders to generate baselines. Some of the chromium.webkit builders don't have main equivalents (like the leak bot) and will need to be actually migrated over, most likely onto the chromium.memory waterfall.
,
Jun 15 2018
Step 3 is also handled in https://crrev.com/c/1096378, except that there will be a few desktop builders (Mac 10.12 retina, Win10 32-bit) still left that we need to move somewhere.
,
Jun 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8536944fe0e5ab9b1bd79fa560b712bc8c26e802 commit 8536944fe0e5ab9b1bd79fa560b712bc8c26e802 Author: Dirk Pranke <dpranke@chromium.org> Date: Sat Jun 16 02:01:29 2018 Add entries to configs for dummy blink builders. We want to shut off most of the chromium.webkit builders and merge their tests into the main builders, but currently the tryserver.blink builders mirror them, and the tryserver.blink builders need to stick around so we can generate baselines. This CL adds a bunch of dummy builder entries on chromium.fyi so that we can switch the tryservers to mirror them, instead. Then we'll be free to delete the chromium.webkit builders. This CL also adds some placeholder entries to mb_config.pyl so that we can rename the tryserver.blink bots to match the new naming scheme. R=hinoka@chromium.org BUG= 853040 NOTRY=true Change-Id: I2e10feb13473a149a74a69915fcac0d80ec6cd28 Reviewed-on: https://chromium-review.googlesource.com/1101999 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#567859} [modify] https://crrev.com/8536944fe0e5ab9b1bd79fa560b712bc8c26e802/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/8536944fe0e5ab9b1bd79fa560b712bc8c26e802/testing/buildbot/generate_buildbot_json.py [modify] https://crrev.com/8536944fe0e5ab9b1bd79fa560b712bc8c26e802/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/8536944fe0e5ab9b1bd79fa560b712bc8c26e802/tools/mb/mb_config.pyl
,
Jun 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83fe32a54467aba8cee9e70f973a5452c4a1e467 commit 83fe32a54467aba8cee9e70f973a5452c4a1e467 Author: Dirk Pranke <dpranke@chromium.org> Date: Sat Jun 16 23:36:21 2018 Remove obsolete chromium.webkit and tryserver.blink configs. The following builders are redundant with builders on the chromium.mac and chromium.win waterfalls, and so we can remove them instead of migrating them to LUCI: - linux_trusty_blink_compile_dbg - linux_trusty_blink_compile_rel - linux_trusty_blink_dbg - win7_blink_compile_dbg - win7_blink_compile_rel - win7_blink_dbg - WebKit Linux Trusty - WebKit Linux Trusty (dbg) - WebKit Mac Builder (dbg) - WebKit Mac10.10 - WebKit Mac10.11 - WebKit Mac10.11 (dbg) - WebKit Mac10.12 - WebKit Win Builder (dbg) - WebKit Win7 - WebKit Win7 (dbg) - WebKit Win x64 Builder - WebKit Win x64 Builder (dbg) They were all either already just placeholder bots that were basically not doing anything interesting or trybots that basically weren't needed. BUG= 853040 NOTRY=true Change-Id: Ifca05f1a570d660bb573cfffe124f2128a84623c Reviewed-on: https://chromium-review.googlesource.com/1096548 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#567900} [modify] https://crrev.com/83fe32a54467aba8cee9e70f973a5452c4a1e467/infra/config/global/cr-buildbucket.cfg [modify] https://crrev.com/83fe32a54467aba8cee9e70f973a5452c4a1e467/infra/config/global/luci-milo-dev.cfg [modify] https://crrev.com/83fe32a54467aba8cee9e70f973a5452c4a1e467/infra/config/global/luci-milo.cfg [modify] https://crrev.com/83fe32a54467aba8cee9e70f973a5452c4a1e467/infra/config/global/luci-scheduler.cfg [modify] https://crrev.com/83fe32a54467aba8cee9e70f973a5452c4a1e467/testing/buildbot/chromium.webkit.json [modify] https://crrev.com/83fe32a54467aba8cee9e70f973a5452c4a1e467/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/83fe32a54467aba8cee9e70f973a5452c4a1e467/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/83fe32a54467aba8cee9e70f973a5452c4a1e467/third_party/blink/tools/blinkpy/common/config/builders.json [modify] https://crrev.com/83fe32a54467aba8cee9e70f973a5452c4a1e467/tools/mb/mb_config.pyl
,
Jun 16 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/f248693d22d5475045c2d3772253d22ad480623f commit f248693d22d5475045c2d3772253d22ad480623f Author: Dirk Pranke <dpranke@chromium.org> Date: Sat Jun 16 23:43:08 2018
,
Jun 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5ada3a7b49c50404b8500edd12e9af32e39689e commit f5ada3a7b49c50404b8500edd12e9af32e39689e Author: Dirk Pranke <dpranke@chromium.org> Date: Sun Jun 17 00:15:22 2018 Add new tryserver.blink builders to milo. I missed these in the previous cleanup, and I apparently also missed one entry for one of the compile-only trybots that I removed. TBR=hinoka@chromium.org BUG= 853040 NOTRY=true Change-Id: I10b5f968fab5c4f065df921eabb68ceec73feb94 Reviewed-on: https://chromium-review.googlesource.com/1103713 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567902} [modify] https://crrev.com/f5ada3a7b49c50404b8500edd12e9af32e39689e/infra/config/global/luci-milo-dev.cfg [modify] https://crrev.com/f5ada3a7b49c50404b8500edd12e9af32e39689e/infra/config/global/luci-milo.cfg
,
Jun 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b0c1289a29757e7cff4af01a92f104b833c0638 commit 8b0c1289a29757e7cff4af01a92f104b833c0638 Author: Dirk Pranke <dpranke@chromium.org> Date: Sun Jun 17 00:36:54 2018 Remove three more builders from chromium.webkit in Milo. This removes three more entries I missed in my last two go-rounds. TBR=hinoka@chromium.org NOTRY=true BUG= 853040 Change-Id: I89e2397d8f0ce8b307281b0eccfae826611a8676 Reviewed-on: https://chromium-review.googlesource.com/1103715 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567903} [modify] https://crrev.com/8b0c1289a29757e7cff4af01a92f104b833c0638/infra/config/global/luci-milo.cfg
,
Jun 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/0b5b54c72ff618c8cb835a44437798be38001479 commit 0b5b54c72ff618c8cb835a44437798be38001479 Author: Dirk Pranke <dpranke@chromium.org> Date: Sun Jun 17 03:04:34 2018 Make win{7,10}-blink-rel-dummy builders 32-bit. They were defaulting to 64-bit builder directories (Release_x64), but the tests are expecting the builds to be in Release instead, since they should be 32-bit builds. TBR=hinoka@chromium.org BUG= 853040 Change-Id: I21a29c9571e3c1a9b7f9550a289a092d12fb5553 Reviewed-on: https://chromium-review.googlesource.com/1103783 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/0b5b54c72ff618c8cb835a44437798be38001479/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
,
Jun 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe177065bdb13e403f8a15c8e3bcdebffb4dd17c commit fe177065bdb13e403f8a15c8e3bcdebffb4dd17c Author: Dirk Pranke <dpranke@chromium.org> Date: Sun Jun 17 16:59:04 2018 Fix test configs for tryserver.blink mac10.12, win builders. This last set of tweaks fixes the swarming configs for a couple of builders. It looks like things should be back to working now. TBR=hinoka@chromium.org NOTRY=true BUG= 853040 Change-Id: Id485754a30a8a22cef5e39e5ea601c78e23cd7d8 Reviewed-on: https://chromium-review.googlesource.com/1103781 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#567912} [modify] https://crrev.com/fe177065bdb13e403f8a15c8e3bcdebffb4dd17c/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/fe177065bdb13e403f8a15c8e3bcdebffb4dd17c/testing/buildbot/waterfalls.pyl
,
Jun 22 2018
Let’s keep Buildbot component scoped to Buildbot-specific bugs and feature requests.
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3b4e9b3630a35341164903eac8516865b441190f commit 3b4e9b3630a35341164903eac8516865b441190f Author: John Budorick <jbudorick@chromium.org> Date: Tue Jul 03 23:46:17 2018 Add netcat to the android docker image. Used by the layout tests on android. Bug: 853040 Change-Id: I85087024eded30793010a20db980df272b3ee908 Reviewed-on: https://chromium-review.googlesource.com/1125321 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/3b4e9b3630a35341164903eac8516865b441190f/docker/docker_devices/android/Dockerfile [modify] https://crrev.com/3b4e9b3630a35341164903eac8516865b441190f/docker/docker_devices/Dockerfile
,
Jul 6
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/cf2ea8542e704ee86a8e66db3258f85bd5f63980 commit cf2ea8542e704ee86a8e66db3258f85bd5f63980 Author: John Budorick <jbudorick@google.com> Date: Fri Jul 06 14:51:09 2018
,
Jul 9
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/7391e757d35391de56012271c5eb1b6afcbc7efa commit 7391e757d35391de56012271c5eb1b6afcbc7efa Author: John Budorick <jbudorick@google.com> Date: Mon Jul 09 16:57:36 2018
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/e9a70e910349722258d3096617a47696e3f9f1d3 commit e9a70e910349722258d3096617a47696e3f9f1d3 Author: John Budorick <jbudorick@chromium.org> Date: Mon Jul 09 19:45:07 2018 android docker: use netcat-openbsd instead of netcat-traditional. Bug: 853040 Change-Id: I0003b61742c4742ba2c43af611ee2c7a5f54b365 Reviewed-on: https://chromium-review.googlesource.com/1129633 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/e9a70e910349722258d3096617a47696e3f9f1d3/docker/docker_devices/android/Dockerfile [modify] https://crrev.com/e9a70e910349722258d3096617a47696e3f9f1d3/docker/docker_devices/Dockerfile
,
Jul 10
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/08da51775acf317158dfcdbbd03f42c132b3fac4 commit 08da51775acf317158dfcdbbd03f42c132b3fac4 Author: John Budorick <jbudorick@google.com> Date: Tue Jul 10 18:02:09 2018
,
Jul 20
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/6fefd689ace5f094d60cde0ac338703cd849070e commit 6fefd689ace5f094d60cde0ac338703cd849070e Author: John Budorick <jbudorick@google.com> Date: Fri Jul 20 01:47:08 2018
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7732d4d0afcd71f550e351bbc368d49f12aa1f72 commit 7732d4d0afcd71f550e351bbc368d49f12aa1f72 Author: John Budorick <jbudorick@chromium.org> Date: Mon Jul 30 19:02:54 2018 Fix many android layout test bugs. They've bitrotten quite a bit :( Bug: 853040 ,824539 Change-Id: I5127a984e7a92a7fc74cd57b9f5945f3abe7c5f6 Reviewed-on: https://chromium-review.googlesource.com/1120431 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#579108} [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/base/test/BUILD.gn [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/content/public/test/nested_message_pump_android.h [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/content/shell/android/BUILD.gn [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/content/shell/app/shell_main_delegate.cc [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/content/shell/browser/layout_test/layout_test_browser_main.cc [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/content/shell/browser/layout_test/scoped_android_configuration.cc [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/content/shell/browser/shell.cc [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/testing/buildbot/chromium.android.json [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/7732d4d0afcd71f550e351bbc368d49f12aa1f72/third_party/WebKit/LayoutTests/TestExpectations
,
Sep 21
@efoo - can I punt this to you since you're tracking the overall migration efforts? If you want me to own tryserver.blink under the theory that'll I'll migrate all of them over, that'd be fine, too, but I think we've divvied up chromium.webkit now and that one's not on me?
,
Dec 6
All associated builders have been migrated to LUCI. Marking as fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Jun 15 2018Here's the approach I'm following: There are three groups of builders: 1) the desktop builders that run the layout tests on different o/s versions. 2) the memory builders (Asan / Msan / Leak / etc.) 3) the android builders For the desktop builders, we need to: 1. Move the tests that are only run on the chromium.webkit builders to their equivalent chromium.{mac,win,linux} builders. https://crrev.com/c/1101918 took care of that. 2. Move the tryserver.blink builders to mirror "dummy" builders since they will no longer have real builder equivalents. https://crrev.com/c/1101999 and https://crrev.com/c/1096378 should take care of that. 3. Shut down the chromium.webkit builders; they will be redundant at that point. 4. Clean up remaining dangling references to the old builder names. For the memory builders, they need to be moved to chromium.memory in some way. For the android builders, the tests should probably be moved to the KitKat builder/tester and the WebKit builder should be shut down.