New issue
Advanced search Search tips

Issue 853028 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

security_NetworkListeners fails due to multiple control files

Project Member Reported by xixuan@chromium.org, Jun 14 2018

Issue description

https://chrome-swarming.appspot.com/task?id=3e191083961d5b10&refresh=10&show_raw=1

06/14 15:15:08.015 ERROR|          autoserv:0320| Found more than one control file with NAME security_NetworkListeners: ['/usr/local/autotest/client/site_tests/security_NetworkListeners/control', '/usr/local/autotest/client/site_tests/security_NetworkListeners/control.bvt-arc']
06/14 15:15:08.015 ERROR|          autoserv:0813| Uncaught Exception, exit_code = 1.
Traceback (most recent call last):
  File "/usr/local/autotest/server/autoserv", line 805, in main
    use_ssp)
  File "/usr/local/autotest/server/autoserv", line 490, in run_autoserv
    control = _stage_control_file(parser, results)
  File "/usr/local/autotest/server/autoserv", line 337, in _stage_control_file
    control_path = _control_path_on_disk(parser.options.control_name)
  File "/usr/local/autotest/server/autoserv", line 322, in _control_path_on_disk
    'Found more than one control file with NAME %s' % control_name)
AutoservError: Found more than one control file with NAME security_NetworkListeners


The command is: /opt/infra-tools/usr/bin/skylab_swarming_worker -client-test -task-name security_NetworkListeners

Looks like the parameters for the command is wrong. What parameters should I pass in in this case?
 
I'm pretty sure that's a problem with the test itself
I don't think we allow control files with the same name.

So control.bvt-arc test should be named security_NetworkListeners.bvt-arc and not security_NetworkListeners

If this bug only affects Skylab, maybe it's because the Skylab dynamic suite is broken?  The two tests shouldn't be run together in the same suite, since one is for bvt-arc and one is for bvt-inline

Comment 3 by xixuan@chromium.org, Jun 14 2018

Can I pass the control path to skylab_swarming_worker? 

Skylab suite fetches these control files, and pass test_name from the control file and pass to skylab_swarming_worker. So if 2 control files have the same test_name, skylab dynamic_suite will pass same thing to skylab_swarming_worker, which is the case here.

If skylab_swarming_worker accepts control path, like, 'client/site_tests/security_NetworkListeners/control', it should be ok.
I don't want to deal with control paths.  We should just contact the test owner and fix the test.
Owner: xixuan@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/13332ae8c1e50483c7940e2f7db3d0f19f06fa17

commit 13332ae8c1e50483c7940e2f7db3d0f19f06fa17
Author: Xixuan Wu <xixuan@chromium.org>
Date: Fri Jun 15 20:30:10 2018

autotest: Rename test security_NetworkListeners for suite bvt-arc.

Skylab doesn't accept the same test_name for different tests, which will
cause 'mutliple control files found' error.

BUG= chromium:853028 
TEST=None

Change-Id: I4ca415543159d785f5809a3b4ddc5f863f8ba005
Reviewed-on: https://chromium-review.googlesource.com/1102996
Reviewed-by: Pohsien Wang <pwang@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/13332ae8c1e50483c7940e2f7db3d0f19f06fa17/client/site_tests/security_NetworkListeners/control.bvt-arc

Status: Fixed (was: Assigned)

Sign in to add a comment