New issue
Advanced search Search tips

Issue 853025 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

config_lib.UseBuildbucketScheduler should be obsolete.

Project Member Reported by dgarr...@chromium.org, Jun 14 2018

Issue description

config_lib.UseBuildbucketScheduler was used to distinguish between master builders which used buildbot and buildbucket scheduling for slaves.

Since there are no remaining slaves scheduled via buildbot, we can clean up that alternative logic and remove the helper function.
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/2e5ff3f9b62df0e9f22cbb024461537c7da175fe

commit 2e5ff3f9b62df0e9f22cbb024461537c7da175fe
Author: Don Garrett <dgarrett@google.com>
Date: Tue Jun 19 18:17:37 2018

build_status: Remove config_lib.UseBuildbucketScheduler.

Stop using an obsolete helper method.

BUG= chromium:853025 
TEST=run_tests

Change-Id: I7f11345260a85c1ea88220718f7007c1ed0b4b2b
Reviewed-on: https://chromium-review.googlesource.com/1102091
Tested-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/2e5ff3f9b62df0e9f22cbb024461537c7da175fe/cbuildbot/build_status_unittest.py
[modify] https://crrev.com/2e5ff3f9b62df0e9f22cbb024461537c7da175fe/cbuildbot/build_status.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84e07da8461b4b76da32670f411417a117a8340c

commit 84e07da8461b4b76da32670f411417a117a8340c
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 19 23:46:40 2018

Roll src/third_party/chromite efd58885b78d..9cccc5ce4fb9 (7 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/efd58885b78d..9cccc5ce4fb9


git log efd58885b78d..9cccc5ce4fb9 --date=short --no-merges --format='%ad %ae %s'
2018-06-19 ayatane@chromium.org sysmon: Ignore chromeos3-* devservers
2018-06-19 dgarrett@google.com gclient: Stop using implicit git_cache_dir.
2018-06-19 lhchavez@google.com Add 'signed' image type examples / docs to cros flash
2018-06-19 dgarrett@google.com chromeos_config: Move toolchain builders to swarming.
2018-06-19 dgarrett@google.com build_status: Remove config_lib.UseBuildbucketScheduler.
2018-06-19 yunlian@google.com cros_gdb: set debug-file-directory for simple chrome.
2018-06-19 vapier@chromium.org pylintrc: convert warnings list into readable ids


Created with:
  gclient setdep -r src/third_party/chromite@9cccc5ce4fb9

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:853866 , chromium:853391 ,chromium:852017, chromium:853969 , chromium:853025 , chromium:843275 ,chromium:None
TBR=chrome-os-gardeners@chromium.org

Change-Id: I38b6b86c7271b9ca0ec2148faa144816e012ac81
Reviewed-on: https://chromium-review.googlesource.com/1107006
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568648}
[modify] https://crrev.com/84e07da8461b4b76da32670f411417a117a8340c/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/93bba6cf593b86260be44d3e8d6b092b4af20de3

commit 93bba6cf593b86260be44d3e8d6b092b4af20de3
Author: Don Garrett <dgarrett@google.com>
Date: Wed Jun 20 21:23:35 2018

simpler_builder: Remove config_lib.UseBuildbucketScheduler.

Stop using an obsolete helper method.

BUG= chromium:853025 
TEST=run_tests

Change-Id: If385c4c3fc3e77bc6e0f7d3c8e56f763ff055380
Reviewed-on: https://chromium-review.googlesource.com/1102092
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/93bba6cf593b86260be44d3e8d6b092b4af20de3/cbuildbot/builders/simple_builders.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e530dc98f55a0c6154631d1be9932b71feb53908

commit e530dc98f55a0c6154631d1be9932b71feb53908
Author: Don Garrett <dgarrett@google.com>
Date: Wed Jun 20 21:23:36 2018

builder_status: Remove config_lib.UseBuildbucketScheduler.

Stop using an obsolete helper method.

BUG= chromium:853025 
TEST=run_tests

Change-Id: I21669775d29c0ab1c63cc8950e9f2147b5e99bfa
Reviewed-on: https://chromium-review.googlesource.com/1102094
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/e530dc98f55a0c6154631d1be9932b71feb53908/lib/builder_status_lib.py
[modify] https://crrev.com/e530dc98f55a0c6154631d1be9932b71feb53908/lib/builder_status_lib_unittest.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62a28772aba9ff619580f8f376dab2a9b20eaad0

commit 62a28772aba9ff619580f8f376dab2a9b20eaad0
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jun 21 00:00:46 2018

Roll src/third_party/chromite c4424eb6803d..5831b835bc15 (7 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c4424eb6803d..5831b835bc15


git log c4424eb6803d..5831b835bc15 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 dgarrett@google.com chromeos_config: Create master-incremental.
2018-06-20 vapier@chromium.org pylintrc: enable bad-builtin for apply & input
2018-06-20 vapier@chromium.org pylintrc: stop disabling exec-used
2018-06-20 dgarrett@google.com builder_status: Remove config_lib.UseBuildbucketScheduler.
2018-06-20 dgarrett@google.com cbuildbot/stages: Remove config_lib.UseBuildbucketScheduler.
2018-06-20 dgarrett@google.com simpler_builder: Remove config_lib.UseBuildbucketScheduler.
2018-06-20 dgarrett@google.com repository: Log cleanup methods.


Created with:
  gclient setdep -r src/third_party/chromite@5831b835bc15

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:851183 ,chromium:None,chromium:None,chromium:853025,chromium:853025,chromium:853025,chromium:853949
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib0d09c8c2eb5246e5e9e7eaa7011ca8f33d7d333
Reviewed-on: https://chromium-review.googlesource.com/1109097
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569096}
[modify] https://crrev.com/62a28772aba9ff619580f8f376dab2a9b20eaad0/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4a7fd9ebd9924f5b8a97428b60fbded10ab742e2

commit 4a7fd9ebd9924f5b8a97428b60fbded10ab742e2
Author: Don Garrett <dgarrett@google.com>
Date: Thu Jun 21 23:30:59 2018

buildbucket_lib: Remove config_lib.UseBuildbucketScheduler.

Stop using an obsolete helper method.

BUG= chromium:853025 
TEST=run_tests

Change-Id: Ieddea152b8c11f38b9932402b84c4e807e6e8ae6
Reviewed-on: https://chromium-review.googlesource.com/1102095
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/4a7fd9ebd9924f5b8a97428b60fbded10ab742e2/lib/buildbucket_lib.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f9aa5862b4f5c7fb901a06607ecb020163d79138

commit f9aa5862b4f5c7fb901a06607ecb020163d79138
Author: Don Garrett <dgarrett@google.com>
Date: Thu Jun 21 23:30:59 2018

config_lib: Remove config_lib.UseBuildbucketScheduler.

Remove the unused helpers:
  config_lib.UseBuildbucketScheduler
  config_lib.IsMasterBuild

BUG= chromium:853025 
TEST=run_tests

Change-Id: Ie76e665cc68568dbae55303aeec61ce1209ce776
Reviewed-on: https://chromium-review.googlesource.com/1102096
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/f9aa5862b4f5c7fb901a06607ecb020163d79138/lib/config_lib_unittest.py
[modify] https://crrev.com/f9aa5862b4f5c7fb901a06607ecb020163d79138/lib/config_lib.py

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9cac21c5d564a4ad329e6f9d743e3708f2b8b12

commit b9cac21c5d564a4ad329e6f9d743e3708f2b8b12
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 22 01:32:08 2018

Roll src/third_party/chromite 0d22d3fa3ae1..694c8ff073d5 (7 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0d22d3fa3ae1..694c8ff073d5


git log 0d22d3fa3ae1..694c8ff073d5 --date=short --no-merges --format='%ad %ae %s'
2018-06-21 metzman@chromium.org [fuzzing] Make env more realistic
2018-06-21 dgarrett@google.com cros_tryjob: Use "default_debug" email template for --debug.
2018-06-21 ayatane@chromium.org Revert "chromeos-infra-go: Disable tests"
2018-06-21 dgarrett@google.com cbuildbot_launch: Tiny tweak to _MaybeCleanDistfiles.
2018-06-21 dgarrett@google.com cbuildbot: Remove .trybot marker concept.
2018-06-21 dgarrett@google.com config_lib: Remove config_lib.UseBuildbucketScheduler.
2018-06-21 dgarrett@google.com buildbucket_lib: Remove config_lib.UseBuildbucketScheduler.


Created with:
  gclient setdep -r src/third_party/chromite@694c8ff073d5

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:648042, chromium:854734 , chromium:852633 ,chromium:None,chromium:None,chromium:853025,chromium:853025
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ifce3485cd2e96d41803591c9a039daf716555a68
Reviewed-on: https://chromium-review.googlesource.com/1111158
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569494}
[modify] https://crrev.com/b9cac21c5d564a4ad329e6f9d743e3708f2b8b12/DEPS

Sign in to add a comment