New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853020 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Use exact value to compute logical resolution on settings page

Project Member Reported by malaykeshav@chromium.org, Jun 14 2018

Issue description

The logical resolution computed on the settings page uses a rounded
value of the zoom factor. This leads to values in that are not what the
actual logical resolution is. Users want to see the exact native 
resolutions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/616ef937bf6ab6a0400b964dd0fdd0aacfbdc119

commit 616ef937bf6ab6a0400b964dd0fdd0aacfbdc119
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Fri Jun 15 17:24:07 2018

Use accurate zoom factor to compute logical resolution

The logical resolution that we display on the display settings page uses
the rounded zoom factor value to do its computation. This gives an
inaccurate logical resolution text. This also results in us being unable
to tag the correct native resolution in the UI.

The rounded number is also used to set the display zoom of the display
which causes problems when the native resolution can only be reached by
a non rounded zoom factor value like in the case of a 1.6 DSF device.

Bug:  853020 
Change-Id: Iba7c70c214ba57f8b21bcac72ebc0e86caeff878
Component: Display settings, display size slider
Reviewed-on: https://chromium-review.googlesource.com/1101936
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567708}
[modify] https://crrev.com/616ef937bf6ab6a0400b964dd0fdd0aacfbdc119/chrome/browser/resources/settings/device_page/display.js

Status: Fixed (was: Started)
Labels: Merge-Request-68
Labels: -Merge-Request-68 Merge-Approved-68
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56833b2a4a597c36a35b39566d41d3bfc5e10dbb

commit 56833b2a4a597c36a35b39566d41d3bfc5e10dbb
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Fri Jun 15 17:33:04 2018

(merge) Use accurate zoom factor to compute logical resolution

The logical resolution that we display on the display settings page uses
the rounded zoom factor value to do its computation. This gives an
inaccurate logical resolution text. This also results in us being unable
to tag the correct native resolution in the UI.

The rounded number is also used to set the display zoom of the display
which causes problems when the native resolution can only be reached by
a non rounded zoom factor value like in the case of a 1.6 DSF device.

Bug:  853020 
Change-Id: Iba7c70c214ba57f8b21bcac72ebc0e86caeff878
Component: Display settings, display size slider
Reviewed-on: https://chromium-review.googlesource.com/1101936
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567708}(cherry picked from commit 616ef937bf6ab6a0400b964dd0fdd0aacfbdc119)
Reviewed-on: https://chromium-review.googlesource.com/1102698
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#377}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/56833b2a4a597c36a35b39566d41d3bfc5e10dbb/chrome/browser/resources/settings/device_page/display.js

Sign in to add a comment