New issue
Advanced search Search tips

Issue 852980 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

loading.desktop/Kenh14 failing on linux and mac

Project Member Reported by chongz@chromium.org, Jun 14 2018

Issue description

linux-perf:
* https://ci.chromium.org/buildbot/chromium.perf/linux-perf/215

Mojo Linux Perf:
* https://ci.chromium.org/buildbot/chromium.perf.fyi/Mojo%20Linux%20Perf/6436
* (Or this one since it's purple) https://ci.chromium.org/buildbot/chromium.perf.fyi/Mojo%20Linux%20Perf/6435

mac-10_13_laptop_high_end-perf:
* https://ci.chromium.org/buildbot/chromium.perf/mac-10_13_laptop_high_end-perf/51

Sample Log from Mojo Linux Perf (linux-perf's log takes forever to load):
```
********************************************************************************
	Operating system: Linux
	                  0.0.0 Linux 3.13.0-141-generic #190-Ubuntu SMP Fri Jan 19 12:52:38 UTC 2018 x86_64
	CPU: amd64
	     family 6 model 94 stepping 3
	     1 CPU
	
	GPU: UNKNOWN
	
	Crash reason:  SIGSEGV
	Crash address: 0x0
	Process uptime: not available
	
	Thread 0 (crashed)
	 0  chrome!blink::StyleRule::ShouldConsiderForMatchingRules(bool) const [css_property_value_set.h : 337 + 0x0]
	    rax = 0x00003177d6484901   rdx = 0x0000000000000000
	    rcx = 0x0000000000000000   rbx = 0x00000c16e77ec3e0
	    rsi = 0x0000000000000000   rdi = 0x00000c16e77de020
	    rbp = 0x00007ffe5eb00f60   rsp = 0x00007ffe5eb00ea8
	     r8 = 0x0000000000000000    r9 = 0x0000000000000fff
	    r10 = 0x00000e0146661040   r11 = 0x0000000000000000
	    r12 = 0x00007ffe5eb01198   r13 = 0x0000000000000000
	    r14 = 0x0000000000000000   r15 = 0x00007ffe5eb00fd0
	    rip = 0x00007f86f9963fb0
	    Found by: given as instruction pointer in context
	 1  chrome!void blink::ElementRuleCollector::CollectMatchingRulesForList<blink::HeapTerminatedArray<blink::RuleData> >(blink::HeapTerminatedArray<blink::RuleData> const*, unsigned int, blink::MatchRequest const&, blink::PartNames*) [element_rule_collector.cc : 158 + 0x5]
	    rbx = 0x00000c16e77ec3e0   rbp = 0x00007ffe5eb00f60
	    rsp = 0x00007ffe5eb00eb0   r12 = 0x00007ffe5eb01198
	    r13 = 0x0000000000000000   r14 = 0x0000000000000000
	    r15 = 0x00007ffe5eb00fd0   rip = 0x00007f86f9a585ba
	    Found by: call frame info
	 2  chrome!blink::ElementRuleCollector::CollectMatchingRules(blink::MatchRequest const&, unsigned int, bool) [element_rule_collector.cc : 227 + 0x13]
	    rbx = 0x0000000000000000   rbp = 0x00007ffe5eb00fb0
	    rsp = 0x00007ffe5eb00f70   r12 = 0x00007ffe5eb00fd0
	    r13 = 0x0000000000000000   r14 = 0x00003578175a8d28
	    r15 = 0x00007ffe5eb01198   rip = 0x00007f86f9a58343
	    Found by: call frame info
	 3  chrome!blink::ScopedStyleResolver::CollectMatchingAuthorRules(blink::ElementRuleCollector&, unsigned int) [scoped_style_resolver.cc : 226 + 0x12]
	    rbx = 0x00000c16e78187b8   rbp = 0x00007ffe5eb01020
	    rsp = 0x00007ffe5eb00fc0   r12 = 0x0000000000000038
	    r13 = 0x00003177d648d540   r14 = 0x00000461883a98b0
	    r15 = 0x0000000000000001   rip = 0x00007f86f9a66b13
	    Found by: call frame info
	 4  chrome!blink::MatchElementScopeRules(blink::Element const&, blink::ScopedStyleResolver*, blink::ElementRuleCollector&) [style_resolver.cc : 241 + 0xd]
	    rbx = 0x00007ffe5eb01198   rbp = 0x00007ffe5eb01050
	    rsp = 0x00007ffe5eb01030   r12 = 0x00003578175a8d28
	    r13 = 0x00007ffe5eb01198   r14 = 0x00003578175a8d28
	    r15 = 0x00003177d648d540   rip = 0x00007f86f9a4aded
	    Found by: call frame info
	 5  chrome!blink::StyleResolver::MatchAuthorRules(blink::Element const&, blink::ElementRuleCollector&) [style_resolver.cc : 399 + 0x12]
	    rbx = 0x00003578175a8d28   rbp = 0x00007ffe5eb01110
	    rsp = 0x00007ffe5eb01060   r12 = 0x00003578175a8d28
	    r13 = 0x00007ffe5eb01198   r14 = 0x0000000000000000
	    r15 = 0x00003177d6484908   rip = 0x00007f86f9a4b3c9
	    Found by: call frame info
	 6  chrome!blink::StyleResolver::StyleForElement(blink::Element*, blink::ComputedStyle const*, blink::ComputedStyle const*, blink::RuleMatchingBehavior) [style_resolver.cc : 497 + 0x8]
	    rbx = 0x00007ffe5eb01198   rbp = 0x00007ffe5eb01d30
	    rsp = 0x00007ffe5eb01120   r12 = 0x00003578175a8d28
	    r13 = 0x00007ffe5eb015f0   r14 = 0x0000000000000000
	    r15 = 0x00003177d6484908   rip = 0x00007f86f9a4c0ba
	    Found by: call frame info
```

Suspecting 1ef408b10e1809223c6939c68657fa53c64e9c07 - [oilpan] Fix LargeObjectPage sizes
However I cannot repro locally.

CCing a few folks who changed 'blink/renderer/' in the 2 Mojo Linux Perf builds to see if it's related.

Going to disable the test.

 
Components: Blink>CSS
Labels: -Pri-3 Pri-1
Add "Blink>CSS" since the crashed stack is in css_property_value_set.h

I think this may affect actual Chrome product, so it would be great if someone from CSS team can help investigate this
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a6e785e209e57345e45d78f9d4052e1d4ca272d

commit 6a6e785e209e57345e45d78f9d4052e1d4ca272d
Author: Chong Zhang <chongz@chromium.org>
Date: Fri Jun 15 00:32:30 2018

Telemetry: Disable loading.desktop/Kenh14 on Linux and Mac

Disable due to failings on linux-perf, Mojo Linux Perf, and
mac-10_13_laptop_high_end-perf.

See bug for sample builds.

Bug:  852980 
Change-Id: Ifa31ba1b34d561afc12c545a8e01e1581b4b2e68
Reviewed-on: https://chromium-review.googlesource.com/1101836
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567498}
[modify] https://crrev.com/6a6e785e209e57345e45d78f9d4052e1d4ca272d/tools/perf/expectations.config

Components: -Blink>CSS Blink>MemoryAllocator>GarbageCollection
Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)
This is related to
  https://chromium-review.googlesource.com/c/chromium/src/+/1098746

Will take a look today.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0fd211f0a1557130f8c192802122d75597eaeb8

commit b0fd211f0a1557130f8c192802122d75597eaeb8
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri Jun 15 05:38:43 2018

[oilpan] LargeObject payload fix

No-try: true
Bug:  chromium:853055 ,  chromium:847679 ,  chromium:852980 
Change-Id: I019eea9d101cbd8e368607e6309a99b0e9779cc2
Reviewed-on: https://chromium-review.googlesource.com/1101605
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567561}
[modify] https://crrev.com/b0fd211f0a1557130f8c192802122d75597eaeb8/third_party/blink/renderer/platform/heap/heap_page.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2018

Labels: merge-merged-3461
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09704f44b190b6b8fbccb5358768fc49647dc056

commit 09704f44b190b6b8fbccb5358768fc49647dc056
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri Jun 15 06:16:52 2018

[oilpan] LargeObject payload fix

No-try: true
Bug:  chromium:853055 ,  chromium:847679 ,  chromium:852980 , chromium:853090
Change-Id: I019eea9d101cbd8e368607e6309a99b0e9779cc2
Reviewed-on: https://chromium-review.googlesource.com/1101605
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#567561}(cherry picked from commit b0fd211f0a1557130f8c192802122d75597eaeb8)
Reviewed-on: https://chromium-review.googlesource.com/1102257
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/branch-heads/3461@{#3}
Cr-Branched-From: c8a271c2b9964bd832b32a9a143f7bf28b658e70-refs/heads/master@{#567544}
[modify] https://crrev.com/09704f44b190b6b8fbccb5358768fc49647dc056/third_party/blink/renderer/platform/heap/heap_page.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b131c59452e25a37d5b36757c0af2e7e643135af

commit b131c59452e25a37d5b36757c0af2e7e643135af
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri Jun 15 06:46:29 2018

Revert "Telemetry: Disable loading.desktop/Kenh14 on Linux and Mac"

This reverts commit 6a6e785e209e57345e45d78f9d4052e1d4ca272d.

Reason for revert: Fix in http://crrev.com/567561

Bug:  852980 

Original change's description:
> Telemetry: Disable loading.desktop/Kenh14 on Linux and Mac
> 
> Disable due to failings on linux-perf, Mojo Linux Perf, and
> mac-10_13_laptop_high_end-perf.
> 
> See bug for sample builds.
> 
> Bug:  852980 
> Change-Id: Ifa31ba1b34d561afc12c545a8e01e1581b4b2e68
> Reviewed-on: https://chromium-review.googlesource.com/1101836
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Commit-Queue: Chong Zhang <chongz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567498}

TBR=kouhei@chromium.org,chongz@chromium.org

Change-Id: I9bc4911f021bd8b2164a19cf146e0e673cd70a92
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  852980 
Reviewed-on: https://chromium-review.googlesource.com/1102058
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567567}
[modify] https://crrev.com/b131c59452e25a37d5b36757c0af2e7e643135af/tools/perf/expectations.config

Status: Fixed (was: Started)

Sign in to add a comment