New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852978 link

Starred by 1 user
Status: Fixed
Owner:
jrumm...@chromium.org
Closed: Jun 2018
Cc:
xhw...@chromium.org
█ joeyparrish@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Don't have a default for encryptionScheme in navigator.requestMediaKeySystemAccess()

Project Member Reported by jrumm...@chromium.org, Jun 14 2018 
If an application omits encryptionScheme in its query, there is no need for the UA to fill one in.  Backward compatibility can still be achieved, and returning null avoids setting any confusing expectations about what is supported.

Proposal updated here: https://github.com/WICG/encrypted-media-encryption-scheme/commit/a7471cee8a199c87c89c0b3b5a4c66008d251912

Chrome should not fill in (or check) the encryptionScheme if it is not specified.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e518197625c3f0195f5f7cf389d53c20b18ab0f9

commit e518197625c3f0195f5f7cf389d53c20b18ab0f9
Author: John Rummell <jrummell@chromium.org>
Date: Fri Jun 15 22:50:19 2018

Don't set encryptionScheme if not specified

https://github.com/WICG/encrypted-media-encryption-scheme/blob/master/explainer.md
has been updated to state "If encryptionScheme from the application is null
or missing, the encryptionScheme fields in the returned configuration must
be null." So updating Chrome to match this.

BUG= 852978 
TEST=updated LayoutTest passes

Change-Id: I7c5c39b93018fdc8208df5f25c0ef6c4f60e83f5
Reviewed-on: https://chromium-review.googlesource.com/1102000
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567818}
[modify] https://crrev.com/e518197625c3f0195f5f7cf389d53c20b18ab0f9/media/blink/key_system_config_selector.cc
[modify] https://crrev.com/e518197625c3f0195f5f7cf389d53c20b18ab0f9/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-encryption-schemes.html
[modify] https://crrev.com/e518197625c3f0195f5f7cf389d53c20b18ab0f9/third_party/blink/renderer/modules/encryptedmedia/media_key_system_access.cc

Comment 2 by jrumm...@chromium.org, Jun 15 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment