New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 852975 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.5% regression in blink_perf.dom at 565673:565758

Project Member Reported by briander...@chromium.org, Jun 14 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jun 14 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=852975

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=f7c797b4b22670d3c0d6e2807bbea3b1a23fef015e07dd91ae84158c8e801cc2


Bot(s) for this bug's original alert(s):

linux-perf
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 15 2018

Cc: afdo-chr...@skia-buildbots.google.com.iam.gserviceaccount.com
Owner: g...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1494398d240000

Roll AFDO from 69.0.3451.0_rc-r1 to 69.0.3453.0_rc-r1 by afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com
https://chromium.googlesource.com/chromium/src/+/f0739e861b6debbe47b69938999af5b3e51347b6
104.9 → 114 (+9.178)

Assigning to sheriff gbiv@chromium.org because "Roll AFDO from 69.0.3451.0_rc-r1 to 69.0.3453.0_rc-r1" is a roll.

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by g...@chromium.org, Jun 15 2018

Status: WontFix (was: Assigned)
WontFix'ing for two reasons:
- Looks like this regression is just 'undoing' the perf improvement from the AFDO roll in r564005
- We reverted to the 3450 profile because of  issue 851539 . When we start autorolling again, we're going to skip the 3453 profile. Jumping to a profile after 3453 might/might not "fix" this for us. If not, I'm sure I'll get another perf bug about it. :)

For context, AFDO profiles are generated by sampling Chrome's execution and feeding that back into the compiler, so the compiler can better optimize Chrome. This process is inherently noisy, so we'll sometimes see benchmarks that are highly sensitive to certain optimizations being performed (read: many of blink's benchmarks) swing around from time to time.

Sign in to add a comment