New issue
Advanced search Search tips

Issue 852969 link

Starred by 1 user
Status: Fixed
Owner:
pprabhu@chromium.org
Closed: Jun 2018
Cc:
bpastene@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Drain and quit a bot once it has been removed from the inventory

Project Member Reported by pprabhu@chromium.org, Jun 14 2018 
Consider the common scenario when a DUT is removed from a skylab-drone.

After CL:*640713, the bot for that DUT on the given drone will quarantine itself, but it will hang around.
Now, if the DUT is added to another drone in the meantime, we'll get two bots for the same DUT (so the same name for the bot) -- one quarantined on the old drone, one good one on the new drone.

We'd like the old bot to quit.

Comment 1 by pprabhu@chromium.org, Jun 14 2018

Cc: bpastene@chromium.org
From bpastene: 

you can send a sigterm to any bot process
and it will gracefully shutdown after the current task
would that work?
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/infra_internal/skylab_inventory/+/2fb0cee330bffec1e61edf8881622f1715a52454

commit 2fb0cee330bffec1e61edf8881622f1715a52454
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Jun 14 21:54:30 2018
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/infra_internal/skylab_inventory/+/7cc14e09226ae1fdb36236939c2a3d2671dc1550

commit 7cc14e09226ae1fdb36236939c2a3d2671dc1550
Author: Prathmesh Prabhu <pprabhu@google.com>
Date: Thu Jun 14 22:27:51 2018

Comment 4 by pprabhu@chromium.org, Jun 14 2018

Status: Started (was: Assigned)
This stack: https://chrome-internal-review.googlesource.com/c/chromeos/chromeos-admin/+/640753/2

#2/#3 validated this works.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/3ead7ec4c6176e6eb7b395b74971d9dd7f539187

commit 3ead7ec4c6176e6eb7b395b74971d9dd7f539187
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Jun 14 23:51:19 2018
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/ae92bfefe6318000c008063e193bc6429d772ea7

commit ae92bfefe6318000c008063e193bc6429d772ea7
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Jun 14 23:51:20 2018

Comment 7 by pprabhu@chromium.org, Jun 15 2018

Status: Fixed (was: Started)
►

Sign in to add a comment