compile failing on Fuchsia builders - unused variable in ipc/handle_attachment_fuchsia.cc |
||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of fdoray@chromium.org compile failing on 4 builders Builders failed on: - Fuchsia ARM64 Cast Audio: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio Failure: ../../ipc/handle_attachment_fuchsia.cc:16:15: error: unused variable 'result' [-Werror,-Wunused-variable] zx_status_t result = ^ 1 error generated.
,
Jun 14 2018
Thanks for the revert. Bitten by the dcheck_always_on difference between try-bots and CQ. :-S
,
Jun 14 2018
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6 commit bfbca08b392dbf8c0be1f4fc487534e4f2993ec6 Author: Wez <wez@chromium.org> Date: Fri Jun 15 02:52:07 2018 Reland "Make base::ScopedZxHandle a zx::handle." This is a reland of e17dbaf1b7b5da00d05fd5d2bf199f9a711ff514 Original change's description: > Make base::ScopedZxHandle a zx::handle. > > - Add the ScopedZxHandle APIs to the base zx::handle. > - Add missing includes. > > This allows ScopedZxHandle to be removed incrementally from call-sites. > > Bug: 852541 > Change-Id: Idc452a450ce2bbe1266e9e0ee266115e2ea38f97 > Reviewed-on: https://chromium-review.googlesource.com/1100132 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567382} TBR: gab, rockot, kmarshall Bug: 852541 , 852958 Change-Id: I66df191da2449007a154595255efc01ac732d110 Reviewed-on: https://chromium-review.googlesource.com/1101742 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#567526} [modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/base/BUILD.gn [modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/base/fuchsia/scoped_zx_handle.h [modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/base/memory/shared_memory_fuchsia.cc [modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/base/test/launcher/test_launcher.cc [modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/content/browser/browser_main_loop.cc [modify] https://crrev.com/bfbca08b392dbf8c0be1f4fc487534e4f2993ec6/ipc/handle_attachment_fuchsia.cc
,
Jun 15 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by fdoray@chromium.org
, Jun 14 2018Status: Assigned (was: Available)