New issue
Advanced search Search tips

Issue 852957 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

potential issue with webvr and fullscreen

Project Member Reported by billorr@chromium.org, Jun 14 2018

Issue description

From webvr slack, reported by bartek.  It looks like in the image that we are sort-of in browsing mode, but not fully initialized.

Filing bug to investigate if it affects other devices, webxr as well as webvr, and investigate if the issue still exists.

---------

Hello! With Webvr enabled in chrome://flags when I requestPresent the display.requestAnimationFrame is never called, but instead I get into vr mode with a screen that shows a grid, a window and a controller, like this:

has anyone seen anything like that? there are not meaningful error in dev tools, but in logcat, I can see some issues related to GVR, pasted below:
06-13 14:23:38.256 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.chrome.browser.vr_shell.keyboard.GvrKeyboardLoaderClient.a(PG:29)
06-13 14:23:38.256 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.chrome.browser.vr_shell.keyboard.GvrKeyboardLoaderClient.getRemoteClassLoader(PG:43)
06-13 14:23:38.256 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.base.JavaHandlerThread.nativeInitializeThread(Native Method)
06-13 14:23:38.256 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.base.JavaHandlerThread.a(PG:34)
06-13 14:23:38.257 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.chrome.browser.vr_shell.keyboard.GvrKeyboardLoaderClient.a(PG:29)
06-13 14:23:38.257 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.chrome.browser.vr_shell.keyboard.GvrKeyboardLoaderClient.getRemoteClassLoader(PG:43)
06-13 14:23:38.257 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.chrome.browser.vr_shell.keyboard.GvrKeyboardLoaderClient.a(PG:17)
06-13 14:23:38.257 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.chrome.browser.vr_shell.keyboard.GvrKeyboardLoaderClient.loadKeyboardSDK(PG:2)
06-13 14:23:38.257 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.base.JavaHandlerThread.nativeInitializeThread(Native Method)
06-13 14:23:38.257 19672 20953 E cr_ChromeGvrKbClient:     at org.chromium.base.JavaHandlerThread.a(PG:34)
06-13 14:23:38.257 19672 20953 E chromium: [ERROR:gvr_keyboard_shim.cc(117)] Failed to load GVR keyboard SDK.


ok, I solved it :slightly_smiling_face: basically - do not turn on fullscreen manually when entering webvr presentation (I realize webvr takes care of that automatically, but I was still setting fullscreen to on for some backwards compatibility reaons) (edited)
that being said: maybe the api should not silently fail in that case :slightly_smiling_face:


Chrome 67.0.3396.87
Tested on two devices with same results:
1/ Android 8.1.0 on Essential PH-1
2/ Android 7.0.0 on Samsung Galaxy S6


with WebVR flag enabled, but that goes without saying :slightly_smiling_face:


 
Labels: -Proj-VR-Shell Proj-VR
Status: Available (was: Untriaged)
Is fullscreen being called before or after requestPresent()?

It seems we should handle before just fine by presenting instead. Perhaps we should reject fullscreen requests when presenting on the screen that would contain the window - similar to how we disable window.requestAnimationFrame().
Those gvr logs are unrelated, but we should really not even be logging them on non-DD-ready phones...
Components: Blink>WebXR
Components: -Blink>WebXR Blink>WebXR>VR
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: Blink>WebXR
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR

Sign in to add a comment