Use presubmits to ensure that changes to CSD proto are reflected on chrome://safe-browsing |
|||
Issue descriptionAny fields that are added to the CSD proto should ideally be shown on chrome://safe-browsing page also. Having a presubmit to check this might be the easiest way to enforce this.
,
Jun 14 2018
Instructions for adding presubmits: https://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
,
Jun 15 2018
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c20e44088143e58f12d516c3fae2f60ff963ed1 commit 0c20e44088143e58f12d516c3fae2f60ff963ed1 Author: Daniel Rubery <drubery@chromium.org> Date: Mon Jun 18 18:32:17 2018 Add Presubmit for changing CSD proto definitions without changing the WebUI logging Bug: 852922 Change-Id: I2db33fb3dd5f13dda3420965e72d8aa92695ffe5 Reviewed-on: https://chromium-review.googlesource.com/1103539 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568086} [add] https://crrev.com/0c20e44088143e58f12d516c3fae2f60ff963ed1/components/safe_browsing/proto/PRESUBMIT.py
,
Jun 18 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vakh@chromium.org
, Jun 14 2018