New issue
Advanced search Search tips

Issue 852920 link

Starred by 1 user
Status: Verified
Owner:
tobiasjs@chromium.org
Closed: Oct 1
Cc:
ntfschr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

WebView support library doesn't provide WebView.getWebViewClient

Project Member Reported by tobiasjs@chromium.org, Jun 14 2018 
This is needed whenever the support library needs to call a callback directly (without going via the WebView APK)

Comment 1 by tobiasjs@chromium.org, Jun 14 2018

Cc: ntfschr@chromium.org

Comment 2 by tobiasjs@chromium.org, Jun 14 2018

Owner: tobiasjs@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by tobiasjs@chromium.org, Jun 14 2018 

Currently SupportLibWebViewChromium doesn't have direct access to the stored WebViewClient object. It only references SharedWebViewChromium.

WebViewContentsClientAdapter currently holds the reference to the WebViewClient object. SupportLibWebViewContentsClientAdapter possibly holds a reference to a WebViewClient boundary interface.

The simplest solution at first glance would be for SharedWebViewChromium to hold a reference to the WebViewClient.

Comment 4 by ntfschr@chromium.org, Jun 14 2018 

Filed http://b/110225598.

Comment 5 by ntfschr@chromium.org, Jun 14 2018

Labels: OS-Android
> SupportLibWebViewContentsClientAdapter possibly holds a reference to a WebViewClient boundary interface.

SupportLibWebViewContentsClientAdapter holds a Nullable WebViewClientBoundaryInterface. When this is non-null, it pins a reference to the WebViewClient (via Proxy/InvocationHandler).

> The simplest solution at first glance would be for SharedWebViewChromium to hold a reference to the WebViewClient.

It should be OK for SharedWebViewChromium to hold the WebViewContentsClientAdapter, which in turn holds both the SupportLibWebViewContentsClientAdapter and WebViewClient.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0bc31531aed4dbabdf26b1bbc4c04109d1f2111

commit f0bc31531aed4dbabdf26b1bbc4c04109d1f2111
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Thu Jun 14 22:54:22 2018

aw: Add support library glue for WebView.getWebViewClient

Bug:  852920 
Change-Id: Icb2e276b25d51958cb1da4865b267212114b41ab
Reviewed-on: https://chromium-review.googlesource.com/1101680
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567458}
[modify] https://crrev.com/f0bc31531aed4dbabdf26b1bbc4c04109d1f2111/android_webview/glue/java/src/com/android/webview/chromium/SharedWebViewChromium.java
[modify] https://crrev.com/f0bc31531aed4dbabdf26b1bbc4c04109d1f2111/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[modify] https://crrev.com/f0bc31531aed4dbabdf26b1bbc4c04109d1f2111/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
[modify] https://crrev.com/f0bc31531aed4dbabdf26b1bbc4c04109d1f2111/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/WebViewProviderBoundaryInterface.java
[modify] https://crrev.com/f0bc31531aed4dbabdf26b1bbc4c04109d1f2111/android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
[modify] https://crrev.com/f0bc31531aed4dbabdf26b1bbc4c04109d1f2111/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromium.java
[modify] https://crrev.com/f0bc31531aed4dbabdf26b1bbc4c04109d1f2111/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java

Comment 7 by tobiasjs@chromium.org, Oct 1

Status: Verified (was: Assigned)
Verified by support library tests.
►

Sign in to add a comment