New issue
Advanced search Search tips

Issue 852916 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Hide SKIPPED Stages

Project Member Reported by dgarr...@chromium.org, Jun 14 2018

Issue description

Cbuildbot currently lists every stage that it even considers running, but the many SKIPPED stages are very noisy, confusing, and don't add much value.

We shouldn't display them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6fa3ea3f3c7c65da5c8a4139cd60711ccaf5555e

commit 6fa3ea3f3c7c65da5c8a4139cd60711ccaf5555e
Author: Don Garrett <dgarrett@google.com>
Date: Fri Jun 15 22:26:24 2018

generic_stages: Stop tagging skipped stages.

Stop generating the step tags for skipped stages. Which will make
build details screens much less noisy, however, any logs associated
with a skipped stage will be tacked on to the end of some semi-random
previous stage, which will make incorrectly skipping a stage even
harder to debug.

BUG= chromium:852916 
TEST=run_tests

Change-Id: I3d30431ae1d009ed9d7fafb47a134d852b4ae6ee
Reviewed-on: https://chromium-review.googlesource.com/1101488
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/6fa3ea3f3c7c65da5c8a4139cd60711ccaf5555e/cbuildbot/stages/generic_stages.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0496b4e506eb35f69d49007198fa1e666d5646df

commit 0496b4e506eb35f69d49007198fa1e666d5646df
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Jun 16 15:52:18 2018

Roll src/third_party/chromite 3a51f2a80a38..ae92f3c98fbe (10 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3a51f2a80a38..ae92f3c98fbe


git log 3a51f2a80a38..ae92f3c98fbe --date=short --no-merges --format='%ad %ae %s'
2018-06-16 chrome-bot@chromium.org Update config settings by config-updater.
2018-06-16 dgarrett@google.com chromeos_config: Require all non-slaves to be important.
2018-06-15 lannm@chromium.org Annotate ScheduleSlavesStage with scheduled build links
2018-06-15 dgarrett@google.com generic_stages: Stop tagging skipped stages.
2018-06-15 dgarrett@google.com chromeos_config: Switch full builders to manifest_version.
2018-06-15 manojgupta@chromium.org Revert "chrome-sdk: Remove absolute path from simple chrome build using goma"
2018-06-15 xixuan@chromium.org SkylabHWTest: Swtich to use nyan_blaze release image to test.
2018-06-15 vapier@chromium.org cros lint: ignore initial UTF-8 BOM in JSON files
2018-06-15 ayatane@chromium.org chromeos-infra-go: Disable tests
2018-06-15 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@ae92f3c98fbe

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:852600,chromium:852916,chromium:851183,chromium:824548,chromium:846610,chromium:845314,chromium:None,chromium:852633
TBR=chrome-os-gardeners@chromium.org

Change-Id: Id646fa70fc50cd3fd10506b67812fb6782bfdf36
Reviewed-on: https://chromium-review.googlesource.com/1103501
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567895}
[modify] https://crrev.com/0496b4e506eb35f69d49007198fa1e666d5646df/DEPS

Owner: dgarr...@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment