[MacViews-Browser] Subfolder Menu doesn't update its position after scrolling |
||||||||
Issue descriptionChrome Version: Canary Version 69.0.3457.2 OS: macOS 10.13 What steps will reproduce the problem? (1) Create a folder on the BMB with a lot of Bookmarks, so you can scroll it (2) Now create a subfolder in that folder (3) Hover over the Subfolder, so that its menu opens (4) Scroll within the Folder Menu, so that the Subfolder changes its position and the Subfolder Menu disappears (5) Now hover again over the Subfolder, so that its menu appears What is the expected result? The menu should open next to its subfolder What happens instead? Subfolder Menu opens at a wrong place. A screencast is attached. Thanks for looking into the issue :) Mehmet
,
Jun 22 2018
,
Jul 2
,
Jul 3
,
Jul 3
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/573df3ecda25f48e93c1985ebfe7954b598c2724 commit 573df3ecda25f48e93c1985ebfe7954b598c2724 Author: spqchan <spqchan@chromium.org> Date: Mon Jul 09 18:45:39 2018 [Views] Update submenu bounds when it's reopened When the submenu is reopened, its bounds doesn't get updated. This causes where if the menu is scrolled after opening the submenu, the submenu will show up in the old position. This CL fixes this issue by updating the bounds if the submenu is reopened. Bug: 852915 Change-Id: I3664cb67f0ea4b15c0802b5fb37af6e7d3c3d789 Reviewed-on: https://chromium-review.googlesource.com/1125202 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#573383} [modify] https://crrev.com/573df3ecda25f48e93c1985ebfe7954b598c2724/ui/views/controls/menu/submenu_view.cc
,
Jul 10
Able to reproduce the issue on Mac 10.13.5 on reported version #69.0.3457.2. Verified the fix on Mac 10.13.5, as per comment#0 on latest chrome version #69.0.3487.0. Attaching screen cast for reference. Observed that the menu opens next to its sub folder. Adding the verified labels as the fix is working as expected. Note : Issue is applicable to OS-Mac only. Thanks...!!
,
Jul 10
,
Jul 12
,
Oct 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e10253a1dd04c572145e283df67ddfdbe6394726 commit e10253a1dd04c572145e283df67ddfdbe6394726 Author: Dong-hee Na <donghee.na92@gmail.com> Date: Sat Oct 06 07:21:11 2018 Bookmarks: Fix multiple empty bookmarks folders growing situation. There is a bug with handling an empty bookmark folder. This bug is reproduced when a bookmark bar has 2 folders and at least one folder is an empty folder. 1. Click one of them, see the "Empty" placeholder 2. Move the cursor to the folder on the side 3. Move the cursor back to the previous folder, you'll see 2 placeholders 4. Keep moving the cursor between the folders and the placeholders count keeps growing. To fix this bug, I 've added the new member method 'HasEmptyMenuItemView()' to check whether SubmenuView has at least one empty menu item. So if submenu does not have visible children but also there is no empty menu item then create an empty menu item. This CL also maintain the functionality which was fixed in crbug/852915. Also, the unit test is also updated to cover this situation. Bug: 880852 , 852915 Change-Id: I61d683f74f6283ba7337c6724b1e267ca91230fb Reviewed-on: https://chromium-review.googlesource.com/c/1254601 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#597417} [modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/menu_item_view.cc [modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/menu_item_view_unittest.cc [modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/submenu_view.cc [modify] https://crrev.com/e10253a1dd04c572145e283df67ddfdbe6394726/ui/views/controls/menu/submenu_view.h |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ellyjo...@chromium.org
, Jun 15 2018Status: Assigned (was: Untriaged)