Autofill suggestions are shown in reverse order in RTL |
|||
Issue descriptionThis is a regression after crrev.com/c/1078871
,
Jun 15 2018
I just checked the passwords in RTL and it seemed OK: English: [Password 1], [Password 2], [Show All] RTL: [Show All], [Password 2], [Password 1] Max, isn't it how it should be for RTL? Because if it's true then it means that passwords and addresses do not use the API in the same way.
,
Jun 18 2018
vasilii@ if passwords are working correctly this means the order of returned suggestions are reversed in RTL. I think that reversal should happen in the UI and not the in the "backend" API.
,
Jun 18 2018
I verified that in case of passwords, FormSuggestionView is created with [Password1, Password2, Show All] list regardless of RTL. They are rendered as I described in Comment #2. It looks correct.
,
Jun 18 2018
I just tested passwords in RTL and the behavior seems incorrect just like autofill.
,
Jun 18 2018
Right, I observe the same behavior. The items are reversed. I asked Max how it's supposed to work.
,
Jun 18 2018
Clearly the first suggestion should not require scrolling to get to. What exactly is the source of confusion?
,
Jun 18 2018
The source of confusion is that the items are always sorted left to right even in RTL in your implementation of the fix.
,
Jun 18 2018
Hmm not correct. In crrev.com/c/1101482 both the UIScrollView and the UIStack view are rotated 180 degrees so that the suggestion are shown from right to left. Here's the recording *after* the fix:
,
Jun 19 2018
Correct, I was confused.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc63b466281f78fd62926cb2d24d37fbecaa1f28 commit bc63b466281f78fd62926cb2d24d37fbecaa1f28 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Jun 19 15:46:23 2018 [AF][IOS] Fixes bug where autofill suggestions are shown in reverse order After crrev.com/c/1078871 that updated FormSuggestionView and FormSuggestionLabel to use AutoLayout, autofill suggestions started showing in reverse order (i.e., the first suggestion was shown last and had to be scrolled to get to). This CL fixes that regression. Bug: 852910 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6aebe579a8ec958ba9a12339396c2b0ddef45406 Reviewed-on: https://chromium-review.googlesource.com/1101482 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#568467} [modify] https://crrev.com/bc63b466281f78fd62926cb2d24d37fbecaa1f28/ios/chrome/browser/autofill/form_suggestion_view.mm
,
Jul 17
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mahmadi@chromium.org
, Jun 14 20183.4 MB
3.4 MB View Download