New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 852891 link

Starred by 1 user
Status: Started
Owner:
bsazonov@chromium.org
Cc:
tedc...@chromium.org
█ bauerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Replace ApiCompatibilityUtils methods with their AppCompat equivalents

Project Member Reported by bsazonov@chromium.org, Jun 14 2018 
A bunch of methods in ApiCompatibilityUtils have equivalents in Support Library. Migration to AppCompat methods is likely to reduce maintenance and binary size, while improving runtime performance and making Chrome code more consistent with the rest of the Android app world, etc. Also, Support Library methods are likely to cover more Android versions/devices.

Examples of methods that can be replaced:
ApiCompatibilityUtils.setPaddingRelative -> ViewCompat.setPaddingRelative
ApiCompatibilityUtils.getPaddingStart -> ViewCompat.getPaddingStart
ApiCompatibilityUtils.getPaddingEnd -> ViewCompat.getPaddingEnd
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d725eaeed246ff99c6fd54644720c67b4f9861fb

commit d725eaeed246ff99c6fd54644720c67b4f9861fb
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Thu Jun 14 23:13:52 2018

[Android] Replace ApiCompatibilityUtils padding methods with ViewCompat

This CL replaces setPaddingRelative, getPaddingStart and getPaddingEnd
from ApiCompatibilityUtils with their ViewCompat equivalents.

Bug: 852891
Change-Id: I566d9dd8ae890611dfdd2223d5b4154a7278672d
Reviewed-on: https://chromium-review.googlesource.com/1098928
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567467}
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderSelectActivity.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContentCoordinator.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsViewBinder.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunView.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsPage.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestionsList.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/page_info/CertificateViewer.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/preferences/ClearBrowsingDataCheckBoxPreference.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/preferences/TextMessageWithLinkAndIconPreference.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/LanguageListBaseAdapter.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/widget/PromoDialogLayout.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/widget/newtab/NewTabButton.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorTextField.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/HintedDropDownAdapter.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/HintedDropDownAdapterWithPlusIcon.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/chrome/android/javatests/src/org/chromium/chrome/browser/widget/PromoDialogTest.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
[modify] https://crrev.com/d725eaeed246ff99c6fd54644720c67b4f9861fb/ui/android/java/src/org/chromium/ui/widget/ViewRectProvider.java
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa

commit 7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa
Author: Boris Sazonov <bsazonov@chromium.org>
Date: Sat Jun 16 15:51:13 2018

[Android] Use MarginLayoutParamsCompat instead of ApiCompatibilityUtils

This CL replaces getMarginStart/setMarginStart and
getMarginEnd/setMarginEnd from ApiCompatibilityUtils with their
equivalents from MarginLayoutParamsCompat.

Bug: 852891
Change-Id: Ibb1e357a054b339c411a793ce64e85c70298e813
Reviewed-on: https://chromium-review.googlesource.com/1102462
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567893}
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUiErrorView.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDialog.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/components/web_contents_delegate_android/java/src/org/chromium/components/web_contents_delegate_android/ColorSuggestionListAdapter.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
[modify] https://crrev.com/7d5e80c8eaf61d2fa218b54e2e2677ae93432eaa/ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java
►

Sign in to add a comment