New issue
Advanced search Search tips

Issue 852889 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Tricium plugin: Add a link to the the run page in tricium-view

Project Member Reported by qyears...@chromium.org, Jun 14 2018

Issue description

The run page (e.g. https://tricium-dev.appspot.com/run/5069141895544832) contains the same information as the tricium-view element: progress/status of one run.

The run ID is fetched when progress is fetched. It would be nice if there was a link from tricium-view to the run page, which could later be changed to contain more information. For example, the text "Tricium Results" could be made into a link.
 
Components: Infra>Platform>Tricium
Components: -Infra>CodeAnalysis
Labels: -Tricium
Owner: diegomtzg@google.com
Status: Assigned (was: Available)
Owner: qyears...@chromium.org
Cc: -diegomtzg@google.com
Status: Available (was: Assigned)
Related:  bug 808464 
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a93547d76486eca28eb67bbe98a9b784d6e17bd2

commit a93547d76486eca28eb67bbe98a9b784d6e17bd2
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Mon Aug 20 16:57:37 2018

[tricium] Stop sending the run ID and URL with each comment

By not sending the robot run ID with each comment,
this should make it so that run ID links are not shown
in comments. This is OK if the run ID link is shown in
tricium-view.

Bug:  808464 ,  852889 
Change-Id: I2ddcc5ca747bde8e164f22a06d09df68300235aa
Reviewed-on: https://chromium-review.googlesource.com/1176443
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/a93547d76486eca28eb67bbe98a9b784d6e17bd2/go/src/infra/tricium/appengine/gerrit/gerrit_test.go
[modify] https://crrev.com/a93547d76486eca28eb67bbe98a9b784d6e17bd2/go/src/infra/tricium/appengine/gerrit/gerrit.go

Status: Fixed (was: Available)
Owner: ----
Status: Available (was: Fixed)
Owner: qyears...@chromium.org
Status: Started (was: Available)
Current status: run link is shown in tricium-view and run ID is also shown in comments although I expected run link to not be shown after #7. There might never have been a deployment after #7, so I'll try deploying now.
After checking the history, I see that the run ID was added again in https://chromium.googlesource.com/infra/infra/+/b2801bfba602f25c57192f13c1c532b65aa18d1f because it's required.
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/91f300f46a18c413fd85ebe784744c6f8034624e

commit 91f300f46a18c413fd85ebe784744c6f8034624e
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Wed Sep 26 18:04:50 2018

[tricium] Re-add run URL with run ID in posted comments

In https://chromium-review.googlesource.com/1176443 I had removed
run ID and URL from comments posted, thinking that maybe the comments
would be posted but without the run ID being displayed, but it turned
out that run ID was required and comments weren't posted without it,
so run ID was re-added.

If we have to include run ID, maybe we'll include the URL as well,
since it might be useful. The expected effect is that the run ID
in comments will become links.

Bug:  852889 
Change-Id: I0c1f139e76184a292be77fb928be2ebcfd769840
Reviewed-on: https://chromium-review.googlesource.com/1245732
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17891}
[modify] https://crrev.com/91f300f46a18c413fd85ebe784744c6f8034624e/go/src/infra/tricium/appengine/gerrit/gerrit_test.go
[modify] https://crrev.com/91f300f46a18c413fd85ebe784744c6f8034624e/go/src/infra/tricium/appengine/gerrit/gerrit.go

Status: Fixed (was: Started)

Sign in to add a comment