Tricium plugin: Add a link to the the run page in tricium-view |
||||||||
Issue descriptionThe run page (e.g. https://tricium-dev.appspot.com/run/5069141895544832) contains the same information as the tricium-view element: progress/status of one run. The run ID is fetched when progress is fetched. It would be nice if there was a link from tricium-view to the run page, which could later be changed to contain more information. For example, the text "Tricium Results" could be made into a link.
,
Jun 15 2018
,
Jun 19 2018
,
Aug 3
,
Aug 13
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/bd7a8827faf7750e5224b43c6fc75e3670370a05 commit bd7a8827faf7750e5224b43c6fc75e3670370a05 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Mon Aug 20 16:54:49 2018 [tricium] Simplify the tricium-view element This change removes some things: - All analyzer status and links - The messages patchset and update time And adds: - A run details link - A doc and bug-filing link Bug: 808464 , 852889 Change-Id: I15738428fb97f483b790aa8f23d8d7f7312ed614 Reviewed-on: https://chromium-review.googlesource.com/1176431 Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/src/main/resources/static/tricium-client.js [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/src/main/resources/static/tricium-view.js [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/test/tricium-client_test.html [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/test/tricium-view_test.html [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/test/example.html [modify] https://crrev.com/bd7a8827faf7750e5224b43c6fc75e3670370a05/src/main/resources/static/tricium-view.html
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/a93547d76486eca28eb67bbe98a9b784d6e17bd2 commit a93547d76486eca28eb67bbe98a9b784d6e17bd2 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Mon Aug 20 16:57:37 2018 [tricium] Stop sending the run ID and URL with each comment By not sending the robot run ID with each comment, this should make it so that run ID links are not shown in comments. This is OK if the run ID link is shown in tricium-view. Bug: 808464 , 852889 Change-Id: I2ddcc5ca747bde8e164f22a06d09df68300235aa Reviewed-on: https://chromium-review.googlesource.com/1176443 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/a93547d76486eca28eb67bbe98a9b784d6e17bd2/go/src/infra/tricium/appengine/gerrit/gerrit_test.go [modify] https://crrev.com/a93547d76486eca28eb67bbe98a9b784d6e17bd2/go/src/infra/tricium/appengine/gerrit/gerrit.go
,
Aug 25
,
Aug 25
,
Sep 26
Current status: run link is shown in tricium-view and run ID is also shown in comments although I expected run link to not be shown after #7. There might never have been a deployment after #7, so I'll try deploying now.
,
Sep 26
After checking the history, I see that the run ID was added again in https://chromium.googlesource.com/infra/infra/+/b2801bfba602f25c57192f13c1c532b65aa18d1f because it's required.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/91f300f46a18c413fd85ebe784744c6f8034624e commit 91f300f46a18c413fd85ebe784744c6f8034624e Author: Quinten Yearsley <qyearsley@chromium.org> Date: Wed Sep 26 18:04:50 2018 [tricium] Re-add run URL with run ID in posted comments In https://chromium-review.googlesource.com/1176443 I had removed run ID and URL from comments posted, thinking that maybe the comments would be posted but without the run ID being displayed, but it turned out that run ID was required and comments weren't posted without it, so run ID was re-added. If we have to include run ID, maybe we'll include the URL as well, since it might be useful. The expected effect is that the run ID in comments will become links. Bug: 852889 Change-Id: I0c1f139e76184a292be77fb928be2ebcfd769840 Reviewed-on: https://chromium-review.googlesource.com/1245732 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#17891} [modify] https://crrev.com/91f300f46a18c413fd85ebe784744c6f8034624e/go/src/infra/tricium/appengine/gerrit/gerrit_test.go [modify] https://crrev.com/91f300f46a18c413fd85ebe784744c6f8034624e/go/src/infra/tricium/appengine/gerrit/gerrit.go
,
Sep 26
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by qyears...@chromium.org
, Jun 15 2018