GPU.BlockStatusForClient3DAPIs UMA histogram unused |
||
Issue descriptionWe are recording GPU.BlockStatusForClient3DAPIs in GpuDataManagerImplPrivate::Are3DAPIsBlockedAtTime() but there is nothing defined in histograms.xml or enums.xml for the histogram and enum. The histogram data isn't available in the UMA dashboard as a result. Is this histogram being used in some way? If not, we should stop recording it and get rid of the code from GpuDataManagerImplPrivate. If it is used, we should add entries in histograms.xml and enums.xml so it's visible in the dashboard.
,
Jun 25 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f1948bd27818c7a10e3d423becdb3564c6a7bb5 commit 6f1948bd27818c7a10e3d423becdb3564c6a7bb5 Author: Kenneth Russell <kbr@chromium.org> Date: Wed Jun 27 01:00:22 2018 Add GPU.BlockStatusForClient3DAPIs histogram. This data's been collected for some time, but due to an oversight wasn't being visualized on the UMA dashboard. Bug: 852884 Tbr: isherman@chromium.org Change-Id: Id22a09ed788fa29172884d6f981e4acef52c4a19 Reviewed-on: https://chromium-review.googlesource.com/1114235 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570607} [modify] https://crrev.com/6f1948bd27818c7a10e3d423becdb3564c6a7bb5/tools/metrics/histograms/enums.xml [modify] https://crrev.com/6f1948bd27818c7a10e3d423becdb3564c6a7bb5/tools/metrics/histograms/histograms.xml
,
Jun 27 2018
This is showing up on the UMA dashboard now. https://uma.googleplex.com/p/chrome/histograms/?endDate=20180625&dayCount=1&histograms=GPU.BlockStatusForClient3DAPIs&fixupData=true&showMax=true&filters=platform%2Ceq%2CW%2Cchannel%2Ceq%2C4%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial It's 20x more likely that all domains are blocked from using WebGL rather than just a single domain. |
||
►
Sign in to add a comment |
||
Comment 1 by kbr@chromium.org
, Jun 25 2018