New issue
Advanced search Search tips

Issue 852878 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 841510



Sign in to add a comment

Create WPT for terminating a worker while WebUSB is in use

Project Member Reported by odejesush@chromium.org, Jun 14 2018

Issue description

Create a WPT for testing the behavior of WebUSB when a worker is terminated while a device is open in the worker. This test would be analogous to usbDevice-iframe.https.html (https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/webusb/usbDevice-iframe.https.html).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edfc097afbe8d1f3917fa2d42738bdac34bfe00c

commit edfc097afbe8d1f3917fa2d42738bdac34bfe00c
Author: Ovidio Henriquez <odejesush@chromium.org>
Date: Tue Aug 28 23:58:27 2018

Update WebUSB terminate child context tests

This change updates tests for WebUSB where a child context is terminated
while having a USB device open. The existing tests are modified to send
the MojoHandle intercepted by MojoInterfaceInterceptor through a
MessageChannel to allow a new test for a worker context to be created.
As a result, the MojoHandle class is made transferable over a
MessageChannel.

Bug:  841510 ,  852878 
Change-Id: Ib7f74d172b9dcc16a4821a4063cfffc196466a88
Reviewed-on: https://chromium-review.googlesource.com/1162351
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586942}
[add] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/webusb-child-test.js
[add] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/webusb-child-test.js.headers
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/webusb-test.js
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/WebKit/LayoutTests/external/wpt/webusb/resources/open-in-iframe.html
[add] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/WebKit/LayoutTests/external/wpt/webusb/resources/open-in-worker.js
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/WebKit/LayoutTests/external/wpt/webusb/resources/usb-helpers.js
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/WebKit/LayoutTests/external/wpt/webusb/usbDevice-iframe.https.html
[add] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/WebKit/LayoutTests/external/wpt/webusb/usbDevice-worker.https.html
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/WebKit/LayoutTests/usb/usbDevice-iframe.html
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/bindings/core/v8/serialization/serialization_tag.h
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.h
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/bindings/core/v8/serialization/transferables.h
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_deserializer.cc
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer.cc
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/bindings/core/v8/serialization/v8_script_value_serializer_test.cc
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/core/messaging/message_port.cc
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/core/messaging/message_port.h
[modify] https://crrev.com/edfc097afbe8d1f3917fa2d42738bdac34bfe00c/third_party/blink/renderer/core/mojo/mojo_handle.h

Status: Fixed (was: Assigned)

Sign in to add a comment