New issue
Advanced search Search tips

Issue 852851 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Don't let the scroll position get reset by a model update

Project Member Reported by taku...@chromium.org, Jun 14 2018

Issue description

Each time the sink list is about to be changed by a model update, we should store the scroll position, then restore that after the update, so that the position is retained.
 

Comment 1 by mfo...@chromium.org, Jun 25 2018

Labels: -Pri-1 Pri-2
Candidate for a post-branch bugfix
Labels: -M-69 -Target-69 Target-70 M-70
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe9438c601fca79e2adc656162bf4457dca6a6fe

commit fe9438c601fca79e2adc656162bf4457dca6a6fe
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Jul 20 18:17:28 2018

[Harmony Cast Dialog] Store and restore scroll position before and after update

Instead of storing the scroll position only when the main button is clicked,
store the position right before each sinks update, so that the scroll position
is retained across updates.

Bug:  852851 
Change-Id: I0052e55eec1de532987dbc211ac04496b67b847d
Reviewed-on: https://chromium-review.googlesource.com/1137345
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576926}
[modify] https://crrev.com/fe9438c601fca79e2adc656162bf4457dca6a6fe/chrome/browser/ui/views/media_router/cast_dialog_view.cc

Status: Fixed (was: Assigned)

Sign in to add a comment