New issue
Advanced search Search tips

Issue 852846 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

EventSender::DoLeapForward should not use a separate |time_offset_|

Project Member Reported by npm@chromium.org, Jun 14 2018

Issue description

I've added a DCHECK comparing two timestamps for Event Timing[1], and noticed that EventSender computers the event timestamp using CurrentTimeTicks() plus a time_offset_[2], thus making my DCHECKs fail. Would it be possilbe to modify the clock instead so that DoLeapForward advances the clock instead of having a separate variable? Otherwise the timestamps used by EventSender are not comparable with other timestamps.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1095736
[2] https://cs.chromium.org/chromium/src/content/shell/test_runner/event_sender.cc?l=2260&rcl=cb482510098927c8b6b9306772d35cfa65e02000
 

Comment 1 by sahel@chromium.org, Jun 21 2018

Owner: nzolghadr@chromium.org
Status: Assigned (was: Untriaged)
nzolghadr@ please take a look

Sign in to add a comment