New issue
Advanced search Search tips

Issue 852844 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 800945



Sign in to add a comment

The wallpaper decoder can't decode png images

Project Member Reported by wzang@chromium.org, Jun 14 2018

Issue description

The new wallpaper picker provides several images in .png format, and the wallpaper decoder in //ash does not support it. Users can't set these wallpapers.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43112301e2844a6d33bb84f575256d5097e8d9a9

commit 43112301e2844a6d33bb84f575256d5097e8d9a9
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jun 14 22:00:06 2018

cros: Change wallpaper decoding format to default

This issue did not show up earlier because the old wallpaper picker
only contained jpeg images.

Also changes |shrink_to_fit| to true.

Bug:  852844 
Change-Id: Ia26a091ee38a6de43454eda0243ff24386e77da8
Reviewed-on: https://chromium-review.googlesource.com/1101400
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567435}
[modify] https://crrev.com/43112301e2844a6d33bb84f575256d5097e8d9a9/ash/wallpaper/wallpaper_utils/wallpaper_decoder.cc

Comment 2 by wzang@chromium.org, Jun 14 2018

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eef973b148054f5c383ad73d9c0d5314d4e834a1

commit eef973b148054f5c383ad73d9c0d5314d4e834a1
Author: Wenzhao (Colin) Zang <wzang@chromium.org>
Date: Wed Jun 27 19:42:54 2018

Revert "cros: Change wallpaper decoding format to default"

This reverts commit 43112301e2844a6d33bb84f575256d5097e8d9a9.

Reason for revert: There's occasional decoding failure on login screen.
Will have to revert this CL first and find a better fix for the original bug.

Original change's description:
> cros: Change wallpaper decoding format to default
> 
> This issue did not show up earlier because the old wallpaper picker
> only contained jpeg images.
> 
> Also changes |shrink_to_fit| to true.
> 
> Bug:  852844 
> Change-Id: Ia26a091ee38a6de43454eda0243ff24386e77da8
> Reviewed-on: https://chromium-review.googlesource.com/1101400
> Reviewed-by: Weidong Guo <weidongg@chromium.org>
> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567435}

TBR=wzang@chromium.org,weidongg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  852844 
Change-Id: Iede6a0c39b14ea7a69f980ea6d47d39628ba31ac
Reviewed-on: https://chromium-review.googlesource.com/1117398
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570866}
[modify] https://crrev.com/eef973b148054f5c383ad73d9c0d5314d4e834a1/ash/wallpaper/wallpaper_utils/wallpaper_decoder.cc

Sign in to add a comment