New issue
Advanced search Search tips

Issue 852838 link

Starred by 1 user
Status: Fixed
Owner:
mcasas@chromium.org
Closed: Aug 20
Cc:
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Changing boundingBox attribute from DOMRect to DOMRectReadOnly

Reported by codei...@gmail.com, Jun 14 2018 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36

Steps to reproduce the problem:
Developers can overwrite boudingBox's properties

What is the expected behavior?
Should not allow developers to overwrite boudingBox's properties

What went wrong?
The boudingBox attribute is defined as DOMRect. It should be DOMRectReadOnly.

Did this work before? No 

Does this work in other browsers? N/A

Chrome version: 69.0.3449.0  Channel: canary
OS Version: OS X 10.12.6
Flash Version:

Comment 1 by codei...@gmail.com, Jun 14 2018 

I am trying to fix this issue.[1]

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1094674

Comment 2 by mcasas@chromium.org, Jun 14 2018

Components: Blink>ImageCapture
Labels: ShapeDetection
Owner: mcasas@chromium.org
Status: Assigned (was: Unconfirmed)
assigned to me as placeholder for codeimpl@gmail.com

Comment 3 by mcasas@chromium.org, Jun 14 2018

Labels: OS-Android OS-Chrome OS-Linux OS-Windows
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae31c11b4ae032f0bb1e972b0530acaef95c9c16

commit ae31c11b4ae032f0bb1e972b0530acaef95c9c16
Author: codeimpl <codeimpl@gmail.com>
Date: Thu Jun 14 23:28:07 2018

Changing boundingBox attribute to DOMRectReadOnly in DetectedFace.idl

The spec[1] says that the boundingBox attribute should be
DOMRectReadOnly instead of DOMRect.

[1] https://wicg.github.io/shape-detection-api/#detectedface

Bug:  852838 
Change-Id: I10714b27ea5cf62c27c3b4c550e3e62b9f1936d2
Reviewed-on: https://chromium-review.googlesource.com/1094674
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#567477}
[add] https://crrev.com/ae31c11b4ae032f0bb1e972b0530acaef95c9c16/third_party/WebKit/LayoutTests/shapedetection/detected-boundingBox-read-only.html
[modify] https://crrev.com/ae31c11b4ae032f0bb1e972b0530acaef95c9c16/third_party/blink/renderer/modules/shapedetection/detected_face.cc
[modify] https://crrev.com/ae31c11b4ae032f0bb1e972b0530acaef95c9c16/third_party/blink/renderer/modules/shapedetection/detected_face.h
[modify] https://crrev.com/ae31c11b4ae032f0bb1e972b0530acaef95c9c16/third_party/blink/renderer/modules/shapedetection/detected_face.idl
[modify] https://crrev.com/ae31c11b4ae032f0bb1e972b0530acaef95c9c16/third_party/blink/renderer/modules/shapedetection/face_detector.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e58e7730533de9c8e7a961738dc3a6750e06239e

commit e58e7730533de9c8e7a961738dc3a6750e06239e
Author: codeimpl <codeimpl@gmail.com>
Date: Thu Jun 21 03:15:30 2018

[ShapeDetection] Change DetectedBarcode.boundingBox to DOMRectReadOnly

The spec[1] says that the boundingBox attribute should be
DOMRectReadOnly instead of DOMRect.

[1] https://wicg.github.io/shape-detection-api/#detectedbarcode

Bug:  852838 
Change-Id: Ic38665031b6e91b77f6251613b1e7ffdf072945c
Reviewed-on: https://chromium-review.googlesource.com/1102444
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569138}
[modify] https://crrev.com/e58e7730533de9c8e7a961738dc3a6750e06239e/third_party/WebKit/LayoutTests/shapedetection/detected-boundingBox-read-only.html
[modify] https://crrev.com/e58e7730533de9c8e7a961738dc3a6750e06239e/third_party/blink/renderer/modules/shapedetection/barcode_detector.cc
[modify] https://crrev.com/e58e7730533de9c8e7a961738dc3a6750e06239e/third_party/blink/renderer/modules/shapedetection/detected_barcode.cc
[modify] https://crrev.com/e58e7730533de9c8e7a961738dc3a6750e06239e/third_party/blink/renderer/modules/shapedetection/detected_barcode.h
[modify] https://crrev.com/e58e7730533de9c8e7a961738dc3a6750e06239e/third_party/blink/renderer/modules/shapedetection/detected_barcode.idl
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcb94b9702c835a9fb7aa625de4340647dc89f18

commit dcb94b9702c835a9fb7aa625de4340647dc89f18
Author: codeimpl <codeimpl@gmail.com>
Date: Wed Jun 27 14:35:29 2018

[ShapeDetection] Change DetectedText.boundingBox to DOMRectReadOnly

The spec[1] says that the boundingBox attribute should be
DOMRectReadOnly instead of DOMRect.

[1] https://github.com/WICG/shape-detection-api/pull/41

Bug:  852838 
Change-Id: I8666d56fcaf4ac77c29b497827b410ec0aeaa916
Reviewed-on: https://chromium-review.googlesource.com/1102838
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#570763}
[modify] https://crrev.com/dcb94b9702c835a9fb7aa625de4340647dc89f18/third_party/WebKit/LayoutTests/shapedetection/detected-boundingBox-read-only.html
[modify] https://crrev.com/dcb94b9702c835a9fb7aa625de4340647dc89f18/third_party/blink/renderer/modules/shapedetection/detected_text.cc
[modify] https://crrev.com/dcb94b9702c835a9fb7aa625de4340647dc89f18/third_party/blink/renderer/modules/shapedetection/detected_text.h
[modify] https://crrev.com/dcb94b9702c835a9fb7aa625de4340647dc89f18/third_party/blink/renderer/modules/shapedetection/detected_text.idl
[modify] https://crrev.com/dcb94b9702c835a9fb7aa625de4340647dc89f18/third_party/blink/renderer/modules/shapedetection/text_detector.cc

Comment 7 by mcasas@chromium.org, Aug 20

Status: Fixed (was: Assigned)
Fixed !
►

Sign in to add a comment