Mac triage: assigning to tommycli@

gm2 triage: load balance tommy?

manukh: I think this is as simple as finding the place where this margin is defined (check the omnibox docs, part 2) and increasing it when IsRefreshUi() is true. If there's some unexpected complication, let me know.

manukh: I might be fixing this as part of my work on bug 853355. Once that's done, I'll let you know if there's anything else to do here.

On further reflection, I'm not sure we want to do this. +bklmn, emilyschechter to see what they think.

Investigating and will follow up with a recommendation. 

Iv'e attached a couple options for this state. Until we fully invest in the new tabbed/scoped search, I think any of these are reasonable for m69. Options 1 or 3 are my preferences right now. 

Deleted: 852828.png 343 KB

	852828.png 343 KB View Download

I like option 3 :)

What do you think about aligning the Search__ text in the pill with the dropdown tsxt? Please see the attached screenshot.

Thanks :)

Deleted: Bildschirmfoto 2018-07-17 um 22.27.27.png 76.7 KB

	Bildschirmfoto 2018-07-17 um 22.27.27.png 76.7 KB View Download

This breaks some of the rules for our pill UI's across Chrome but might be a reasonable deviation for this layout. Thoughts jdonnelly@?

bklmn: thanks for the options. 2 and 3 are more work so I'll go with 1 for now. We'll start working on scoped search improvement soon and then we can tackle something like option 3.

Was about to say the same thing as Justin did in c#14. Let's do 1 for now and plan to do something like 3 in the future.

Here's a screenshot of my WIP CL. It's intended to match Option 1 in #11.

Deleted: keyword-search-with-space.PNG 8.8 KB

	keyword-search-with-space.PNG 8.8 KB View Download

Looks great, thanks.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e684390b18473360b24f567487f0e0cc8af3fb6c

commit e684390b18473360b24f567487f0e0cc8af3fb6c
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Thu Jul 19 22:06:07 2018

[omnibox] Adjust the Refresh keyword view layout to match suggestions.

See bug for screenshot.

Bug:  852828 
Change-Id: I6eb74b885cfc4a50ad9f03704b6a20391f70180b
Reviewed-on: https://chromium-review.googlesource.com/1143898
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576654}
[modify] https://crrev.com/e684390b18473360b24f567487f0e0cc8af3fb6c/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/e684390b18473360b24f567487f0e0cc8af3fb6c/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/e684390b18473360b24f567487f0e0cc8af3fb6c/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/e684390b18473360b24f567487f0e0cc8af3fb6c/chrome/browser/ui/views/location_bar/location_icon_view.h
[modify] https://crrev.com/e684390b18473360b24f567487f0e0cc8af3fb6c/chrome/browser/ui/views/location_bar/selected_keyword_view.cc
[modify] https://crrev.com/e684390b18473360b24f567487f0e0cc8af3fb6c/chrome/browser/ui/views/location_bar/selected_keyword_view.h

Able to reproduce the issue on chrome version 69.0.3456.0(build without fix)
Verified the fix on Mac 10.12.6, Windows-10 and Ubuntu 14.04 using Chrome version #69.0.3497.0 as per the comment #0.
Attaching screenshot for reference.
Observed "Tab-To-Search Label is aligned with the Drop-down Results"
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks!

Deleted: 852828.png 129 KB

	852828.png 129 KB View Download