New issue
Advanced search Search tips

Issue 852824 link

Starred by 1 user
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Jun 2018
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Adding HeavyPageCapping UKM

Project Member Reported by ryansturm@chromium.org, Jun 14 2018 
The goal of this UKM is to provide details from the PLM UKM pipeline to better understand Heavy Page Capping.

Heavy page capping allows users to pause loading sub resources when Chrome informs them that the page is above a certain size.

Specifically, I'd like to measure 3 states per page load:

previews::page_load_capping

0 (or not added at all) - The infobar was not shown
1 - The infobar was shown, but the user did not interact with it
2 - The infobar was shown, and the user paused the page
3 - The infobar was shown, and the user paused then resumed the page
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67e1bc9adbca508778c7442a6b20d24efaf12e4c

commit 67e1bc9adbca508778c7442a6b20d24efaf12e4c
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Mon Jun 18 20:42:32 2018

Adding UKM aroung the final state of PageLoadCapping

This UKM is recorded at the same time as the PageLoad UKM so that the
data can be tied together. This does not record on pages that did not
show the InfoBar. Otherwise, it records 3 states: (a) InfoBar shown, but
page not paused (b) page paused (c) page paused then resumed.

Bug:  852824 
Change-Id: I912774c3c9651e342bfa7435e6adf33bd194fb87
Reviewed-on: https://chromium-review.googlesource.com/1101831
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568146}
[modify] https://crrev.com/67e1bc9adbca508778c7442a6b20d24efaf12e4c/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc
[modify] https://crrev.com/67e1bc9adbca508778c7442a6b20d24efaf12e4c/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h
[modify] https://crrev.com/67e1bc9adbca508778c7442a6b20d24efaf12e4c/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/67e1bc9adbca508778c7442a6b20d24efaf12e4c/tools/metrics/ukm/ukm.xml

Comment 2 by ryansturm@chromium.org, Jun 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment