Dynamic interstitials should be configurable to trigger for non-overridable errors only |
||
Issue descriptionSometimes it would make sense to deploy a dynamic interstitial for non-overridable SSL errors only (for example, a MITM interstitial where we don't want to remove the ability to click through errors so we only want to show it on errors that wouldn't be bypassable anyway). We can add a boolean field to the DynamicInterstitial proto so that the dynamic interstitial only matches for nonoverridable errors.
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b21d8414676af299b6f5dac93e9bda9be34dc9af commit b21d8414676af299b6f5dac93e9bda9be34dc9af Author: Livvie Lin <livvielin@chromium.org> Date: Thu Aug 16 04:05:22 2018 Add show_only_for_nonoverridable_errors flag for dynamic interstitials. This cl adds a parameter to MatchDynamicInterstitial (set to false by default) to pass along whether an SSL error is overridable, and optionally not return a match if it is. Bug: 852811 Change-Id: I3f8bd225cb793337b8412fcc63750f6f74c6f5bd Reviewed-on: https://chromium-review.googlesource.com/1173412 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#583532} [modify] https://crrev.com/b21d8414676af299b6f5dac93e9bda9be34dc9af/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/b21d8414676af299b6f5dac93e9bda9be34dc9af/chrome/browser/ssl/ssl_error_assistant.cc [modify] https://crrev.com/b21d8414676af299b6f5dac93e9bda9be34dc9af/chrome/browser/ssl/ssl_error_assistant.h [modify] https://crrev.com/b21d8414676af299b6f5dac93e9bda9be34dc9af/chrome/browser/ssl/ssl_error_assistant.proto [modify] https://crrev.com/b21d8414676af299b6f5dac93e9bda9be34dc9af/chrome/browser/ssl/ssl_error_assistant_unittest.cc [modify] https://crrev.com/b21d8414676af299b6f5dac93e9bda9be34dc9af/chrome/browser/ssl/ssl_error_handler.cc
,
Aug 16
|
||
►
Sign in to add a comment |
||
Comment 1 by livvielin@chromium.org
, Aug 6Status: Assigned (was: Available)