New issue
Advanced search Search tips

Issue 852799 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

continuous scroll long press on arrow down button is interrupted

Reported by mihai...@gmail.com, Jun 14 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36

Steps to reproduce the problem:
1. go to http://scrollmagic.io/examples/advanced/infinite_scrolling.html
2. long press arrow down button
3. loading is interrupted 

What is the expected behavior?
Page continuously loads new items.

What went wrong?
loading is interrupted . See attached screen recording

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 67.0.3396.87  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

Observations:
 Moving the mouse over the arrow button in-out, makes scroll requests.
 Mouse wheel works fine.
 IE, FF also works fine.
 This is an example site, i have the same issue using different implementation.
 
screencast-scrollmagic.io-2018.06.14-18-30-06.webm
3.0 MB View Download
Labels: Needs-Triage-M67
Labels: Triaged-ET M-69 FoundIn-69 Target-69 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on chrome reported version 67.0.3396.87 and on latest chrome 69.0.3457.0 using Windows-7/10, Ubuntu 14.04 and Mac 10.12.6. As this issue is seen from M-60(60.0.3112.0), hence considering it as Non-Regression and marking it as Untriaged.

Thanks!

Comment 3 by bokan@chromium.org, Jun 15 2018

Cc: bokan@chromium.org
Labels: -Pri-2 Pri-3
Owner: chaopeng@chromium.org
Status: Assigned (was: Untriaged)
This should be a really simple fix, looks like we start a timer that fires regularly while the mouse is down. Once we can't scroll anymore we cancel the timer. Looks like we could just avoid canceling the timer: https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/scroll/scrollbar.cc?g=0&l=215
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d11bdee18c8696f31c0fe01c27fa926b71d2f34

commit 1d11bdee18c8696f31c0fe01c27fa926b71d2f34
Author: chaopeng <chaopeng@chromium.org>
Date: Fri Jul 06 15:10:01 2018

Keep scroll timer when user press on scrollbar button.

Currently, we stop the scroll timer when scrollbar reach the begin
or end of track. This breaks the scrolling on infinite scrolling page
since infinite scrolling page will load new content when scrollbar
reach the end of track.

In this patch, we keep the scroll timer for user press on scrollbar
button.

Bug:  852799 
Change-Id: I16b06a5e3683f01164b4e12e364ea732d73cfd22
Reviewed-on: https://chromium-review.googlesource.com/1127144
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572977}
[modify] https://crrev.com/1d11bdee18c8696f31c0fe01c27fa926b71d2f34/third_party/blink/renderer/core/layout/scrollbars_test.cc
[modify] https://crrev.com/1d11bdee18c8696f31c0fe01c27fa926b71d2f34/third_party/blink/renderer/platform/scroll/scrollbar.cc

Status: Fixed (was: Assigned)

Sign in to add a comment