New issue
Advanced search Search tips

Issue 852787 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task



Sign in to add a comment

Omnibox changes

Project Member Reported by pschaffner@chromium.org, Jun 14 2018

Issue description

1) Change resting and focused font size back to 17pt for all size classes.
2) In Compact x Any and Any x Compact, make the cancel button 17pt.
3) Change tint color for cursor and selection UI back to holy blue: #1A73E8
4) Update lock icon (omnibox_connection_secure*.png): https://drive.google.com/open?id=1SCEI15MXVkeWtjrqz6LQRR3S0JhYz0bH
5) Clear button should remain visible when in focused omnibox state with keyboard dismissed
6) Adjust clear button trailing edge inset to 4pt.
7) Clear asset (omnibox_clear*.png) available here: https://drive.google.com/open?id=1SCEI15MXVkeWtjrqz6LQRR3S0JhYz0bH
8) Normal clear button tint color: black @ 0.3 alpha; incognito: white @ 0.5 alpha (same as share/voice icons)
9) Pre-edit selection color should be holy blue (#1A73E8) @ 0.2 alpha
10) Incognito cancel button should be white
... (maybe more)

 
Labels: medium
Status: Started (was: Assigned)
Cc: pschaffner@chromium.org
First CL will address points 1, 2, 3, 6, 9, 10. Clear button (5-8) will require more work. Lock icon (4) will be updated separately. 
Uploaded https://chromium-review.googlesource.com/#/c/chromium/src/+/1101199 to swap the secure state icon.
Filed  crbug.com/854093  to update the NTP fakebox.
Cc: stkhapugin@chromium.org
 Issue 821819  has been merged into this issue.
Did the CL addressing 1, 2, 3, 6, 9, 10 land?
I still see the fonts size as 19.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e188de02461f60b6a12251723dc5f62f0a3d63

commit b9e188de02461f60b6a12251723dc5f62f0a3d63
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jun 20 01:48:55 2018

[UI Refresh] Change omnibox and location bar styling.

Updates fonts, spaces, colors in omnibox-related code to match the new
specs.

Bug:  852787 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibe22b985011ce7ed3da9f83291f293e3942728c4
Reviewed-on: https://chromium-review.googlesource.com/1101026
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568693}
[modify] https://crrev.com/b9e188de02461f60b6a12251723dc5f62f0a3d63/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
[modify] https://crrev.com/b9e188de02461f60b6a12251723dc5f62f0a3d63/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
[modify] https://crrev.com/b9e188de02461f60b6a12251723dc5f62f0a3d63/ios/chrome/browser/ui/omnibox/omnibox_container_view.mm
[modify] https://crrev.com/b9e188de02461f60b6a12251723dc5f62f0a3d63/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
[modify] https://crrev.com/b9e188de02461f60b6a12251723dc5f62f0a3d63/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
[modify] https://crrev.com/b9e188de02461f60b6a12251723dc5f62f0a3d63/ios/chrome/browser/ui/toolbar/buttons/toolbar_button_factory.mm
[modify] https://crrev.com/b9e188de02461f60b6a12251723dc5f62f0a3d63/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
[modify] https://crrev.com/b9e188de02461f60b6a12251723dc5f62f0a3d63/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31aca9d33800ed09b0bf93e5768dbb3c4930acbf

commit 31aca9d33800ed09b0bf93e5768dbb3c4930acbf
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jun 20 09:19:14 2018

[iOS] Update location_bar_secure icon.

Update the location_bar_secure icon to a new one.

Bug:  852787 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iea6784608548fd25463df21de3952dcdb87745b0
Reviewed-on: https://chromium-review.googlesource.com/1101199
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568772}
[modify] https://crrev.com/31aca9d33800ed09b0bf93e5768dbb3c4930acbf/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure.png
[modify] https://crrev.com/31aca9d33800ed09b0bf93e5768dbb3c4930acbf/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@2x.png
[modify] https://crrev.com/31aca9d33800ed09b0bf93e5768dbb3c4930acbf/ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@3x.png

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cc8554573246b80d62d58d73c58fec0c5684e1e

commit 5cc8554573246b80d62d58d73c58fec0c5684e1e
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jun 20 12:46:46 2018

Implement a custom clear button with custom graphics.

Bug:  852787 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ied16b9651281b7907e8628752938a2d6b42ae9c3
Reviewed-on: https://chromium-review.googlesource.com/1106337
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568802}
[modify] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/omnibox/BUILD.gn
[modify] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
[modify] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
[modify] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/omnibox/resources/BUILD.gn
[add] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/omnibox/resources/omnibox_clear_icon.imageset/Contents.json
[add] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/omnibox/resources/omnibox_clear_icon.imageset/omnibox_clear_icon.png
[add] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/omnibox/resources/omnibox_clear_icon.imageset/omnibox_clear_icon@2x.png
[add] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/omnibox/resources/omnibox_clear_icon.imageset/omnibox_clear_icon@3x.png
[modify] https://crrev.com/5cc8554573246b80d62d58d73c58fec0c5684e1e/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm

Status: Verified (was: Fixed)
Verified in 69.0.3473.0 Canary, iPhone X  iOS 11.4, iPad Air  iOS11.4

https://drive.google.com/file/d/1cuu8Gz_KvxXDRpmwjQ0QLGQpdngIHeJO/view
https://drive.google.com/file/d/1AAUIvRuu5gLWyCdtvVuxaL_SOgZvTj_r/view

Sign in to add a comment