New issue
Advanced search Search tips

Issue 852786 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Proj-Servicification


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

content_browsertests flaky on Win10 x64 dbg

Project Member Reported by jbudorick@chromium.org, Jun 14 2018

Issue description

Comment 1 by thakis@chromium.org, Jun 14 2018

Components: Internals>Services>Network
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d96ee6fa13d84b9e573266f9de24f3fe94ed1bc5

commit d96ee6fa13d84b9e573266f9de24f3fe94ed1bc5
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Jun 15 17:20:11 2018

Disable network_service_content_browsertests on Win10 x64 dbg.

Change-Id: I639edf669730918329f3368c73440062c3df1997
Bug: 839419,818832,852786
Reviewed-on: https://chromium-review.googlesource.com/1100962
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567705}
[modify] https://crrev.com/d96ee6fa13d84b9e573266f9de24f3fe94ed1bc5/testing/buildbot/chromium.win.json
[modify] https://crrev.com/d96ee6fa13d84b9e573266f9de24f3fe94ed1bc5/testing/buildbot/test_suite_exceptions.pyl

Comment 3 by jam@chromium.org, Jun 15 2018

Cc: jam@chromium.org rhalavati@google.com dmazz...@chromium.org
 Issue 852711  has been merged into this issue.

Comment 4 by dxie@chromium.org, Jun 19 2018

Labels: Proj-Servicification-Canary

Comment 5 by jam@chromium.org, Jun 26 2018

Labels: -Proj-Servicification-Canary Hotlist-KnownIssue
Summary: content_browsertests flaky on Win10 x64 dbg (was: Multiple network service test suites flaky / broken on Win10 x64 dbg)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec52747a5abc25a862843edca761104b3c319764

commit ec52747a5abc25a862843edca761104b3c319764
Author: Gabriel Charette <gab@chromium.org>
Date: Mon Jan 14 16:16:49 2019

[ui_controls] Unflake Send*NotifyWhenDone() on Windows

ui_controls::Send*NotifyWhenDone() can be flaky when invoked after
ui_controls::Send*() as the former can decide to notify based on
observing a yet-to-be-processed event from the latter (or even a
yet-to-be-processed event emitted by unrelated code) and thus notify too
early, resuming and testing conditions that have yet to be met.

Solution: defer the notification if the system queue has pending events
of the same type awaiting dispatch.

Note: mouse move can be repeated indefinitely during a drag, as such we
consider a mouse move complete when it hits the target regardless of
remaining mouse move messages in the queue.

@ BUG OWNERS : This might unflake many currently disabled tests. I've
CC'ed interactive_ui_tests + Windows bugs, please try to re-enable your
test after this CL if you think it might be related.

Bug:  892228 , 640996, 897801,893078,876224,875443,873110,852786,850343,848049,846695,840369,798492,756338,751031,665296,651906,499858,468660,419468,238347,131612,106489,97777,92467
Change-Id: I548856a3948ff71a145435799b4ba3e689561f14
Reviewed-on: https://chromium-review.googlesource.com/c/1392178
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622470}
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
[modify] https://crrev.com/ec52747a5abc25a862843edca761104b3c319764/ui/base/test/ui_controls_internal_win.cc

Sign in to add a comment