New issue
Advanced search Search tips

Issue 852769 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 651778



Sign in to add a comment

ErrorEvent seems to be missing from Workers.

Project Member Reported by aerotwist@chromium.org, Jun 14 2018

Issue description

'ErrorEvent' in self returns false for me in a worker (true in window), but according to the spec at https://html.spec.whatwg.org/#the-errorevent-interface it should be exposed on Window and Worker.
 
Components: Blink>Workers
Owner: nhiroki@chromium.org
Status: Assigned (was: Untriaged)
nhiroki: Could you triage this?
Cc: nhiroki@chromium.org
Owner: kdillon@chromium.org
Oh... this is failing only on Chrome according to tkent@'s link.

kdillon@: Do you have a bandwidth to work on this? If not, feel free to reassign this to me :)
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ef7e4c4dcae40ae9c40823847f748e80346ae71

commit 9ef7e4c4dcae40ae9c40823847f748e80346ae71
Author: Katie Dillon <kdillon@chromium.org>
Date: Thu Dec 06 19:24:16 2018

Exposing ErrorEvent interface to workers.

According to current specs (https://html.spec.whatwg.org/#the-errorevent-interface)
the ErrorEvent interface should be exposed to the window and workers.

Bug:  852769 
Change-Id: I38b057113fa6f56d473b75a7f328635f46f73af5
Reviewed-on: https://chromium-review.googlesource.com/c/1362003
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614443}
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/renderer/core/events/error_event.idl
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/web_tests/TestExpectations
[delete] https://crrev.com/042756580e2aa3917d3215744f8428d3a4b672b4/third_party/blink/web_tests/external/wpt/WebIDL/ecmascript-binding/no-regexp-special-casing.any.worker-expected.txt
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/web_tests/external/wpt/workers/semantics/interface-objects/001.worker-expected.txt
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/web_tests/external/wpt/workers/semantics/interface-objects/003-expected.txt
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/9ef7e4c4dcae40ae9c40823847f748e80346ae71/third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt

Status: Fixed (was: Started)
Labels: M-73
kdillon@: Thank you for fixing this!

Sign in to add a comment