New issue
Advanced search Search tips

Issue 852765 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Ill in v8::internal::PatternRewriter::VisitImportCallExpression

Project Member Reported by ClusterFuzz, Jun 14 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5991195076198400

Fuzzer: libFuzzer_javascript_parser_proto_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Ill
Crash Address: 0x00000161073e
Crash State:
  v8::internal::PatternRewriter::VisitImportCallExpression
  v8::internal::PatternRewriter::Visit
  v8::internal::PatternRewriter::RecurseIntoSubpattern
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=545705:545706

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5991195076198400

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 14 2018

Components: Blink>JavaScript>Parser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 14 2018

Cc: marja@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.

Comment 3 by ishell@chromium.org, Jun 22 2018

Owner: ishell@chromium.org
Status: Assigned (was: Untriaged)
Owner: marja@chromium.org
This reproes with plain d8 and the repro case is:

( import ( foo ) ) =>

Debugging notes:

NOT_A_PATTERN(ImportCallExpression) generates this code:

void PatternRewriter::VisitImportCallExpression(v8::internal::Node*) { UNREACHABLE(); }

... and that's where the Unreachable comes from.

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f128acee3b31fc072bebfbf665711a3cb6df543b

commit f128acee3b31fc072bebfbf665711a3cb6df543b
Author: Marja Hölttä <marja@chromium.org>
Date: Mon Jul 16 07:57:19 2018

[parser] Fix import in arrow function parameters.

BUG= chromium:852765 

Change-Id: Iaba84f6e52b08b3aee4c1529701239c049dceb9a
Reviewed-on: https://chromium-review.googlesource.com/1128875
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54450}
[modify] https://crrev.com/f128acee3b31fc072bebfbf665711a3cb6df543b/src/parsing/parser-base.h
[modify] https://crrev.com/f128acee3b31fc072bebfbf665711a3cb6df543b/test/cctest/test-parsing.cc
[add] https://crrev.com/f128acee3b31fc072bebfbf665711a3cb6df543b/test/mjsunit/regress/regress-852765.js

Project Member

Comment 7 by ClusterFuzz, Jul 17

ClusterFuzz has detected this issue as fixed in range 575246:575249.

Detailed report: https://clusterfuzz.com/testcase?key=5991195076198400

Fuzzer: libFuzzer_javascript_parser_proto_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Ill
Crash Address: 0x00000161073e
Crash State:
  v8::internal::PatternRewriter::VisitImportCallExpression
  v8::internal::PatternRewriter::Visit
  v8::internal::PatternRewriter::RecurseIntoSubpattern
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=545705:545706
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=575246:575249

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5991195076198400

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jul 17

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5991195076198400 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment