Issue metadata
Sign in to add a comment
|
Section headers not scrolling as expected in Recent Tabs in grid |
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3458.0 canary OS: iOS UIrefresh flag enabled. Launch Chrome, enter the tab grid, let remote tabs sync, swipe to the remote tabs panel, then scroll. The section header for the remote device stays fixed, but the content for that section is visible above it during scrolling. See attached video.
,
Jun 15 2018
This is due to content inset. Need a little more investigation, but this should be an easy fix.
,
Jun 15 2018
,
Jun 15 2018
CL in-flight.
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b7c5a3f819d31e467ef6999222dc40aea7e170c commit 5b7c5a3f819d31e467ef6999222dc40aea7e170c Author: edchin <edchin@chromium.org> Date: Fri Jun 15 09:53:34 2018 [ios] Fix content inset behavior in recent tabs in tab grid Previously, the section header in recent tabs in tab grid was a little low, and content would scroll up behind the section header. This CL fixes that by adjusting the content inset behavior so that the section header is flush up against the top toolbar. Bug: 852721 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1ab1f2f926b41cc7c874fc8b2250163b90bc4615 Reviewed-on: https://chromium-review.googlesource.com/1102194 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567594} [modify] https://crrev.com/5b7c5a3f819d31e467ef6999222dc40aea7e170c/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Jun 15 2018
,
Jun 20 2018
The NextAction date has arrived: 2018-06-20 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by edchin@chromium.org
, Jun 14 2018