Update Incognito shield in App Switcher |
|||||||
Issue descriptionCurrent implementation see attachment. Proposed implementation: Solid background #222222
,
Jun 27 2018
Yeah we should make this change before then if possible (so that it makes it in M69).
,
Jun 27 2018
Just to be clear: are you saying that this change *which doesn't affect the UI Refresh work* is important to get into M69? Can you explain why you feel this is a priority on a par with the UI Refresh?
,
Jun 27 2018
I think this must be a misunderstanding. Pete probably means that we need to have the tab grid background as Solid #222222 (for UI Refresh Phase 1). Pete: Please confirm. Thanks.
,
Jun 27 2018
As per offline discussion, proposed to use startup screen.
,
Jun 27 2018
,
Jun 27 2018
Got it, I'll use the current startup image as the shield to hide incognito. Thanks!
,
Jun 27 2018
,
Jun 27 2018
This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label. All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c76065c44e6e0ced7c1c956d394633590a33057 commit 9c76065c44e6e0ced7c1c956d394633590a33057 Author: Justin Cohen <justincohen@google.com> Date: Wed Jun 27 16:46:33 2018 [ios] Use launch screen for incognito blocker. Bug: 852705 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I611e9625e988e077f61e71e58a7f44b741a20eab Reviewed-on: https://chromium-review.googlesource.com/1116702 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570800} [modify] https://crrev.com/9c76065c44e6e0ced7c1c956d394633590a33057/ios/chrome/app/application_delegate/app_state.mm
,
Jun 27 2018
,
Jul 3
Launch screen is now displayed as incognito shield. Verified on M69.0.3480.0 canary iOS: 11.4, 12, 10.3.3 Device: iPad Pro, iPhoneX, iPhone5S |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by marq@chromium.org
, Jun 26 2018Labels: -Pri-1 -Proj-UIRefresh Pri-2
Owner: martijnb@chromium.org
Status: Assigned (was: Untriaged)