New issue
Advanced search Search tips

Issue 852705 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Update Incognito shield in App Switcher

Project Member Reported by martijnb@chromium.org, Jun 14 2018

Issue description

Current implementation see attachment. 

Proposed implementation: Solid background #222222
 
IMG_0849.PNG
5.6 MB View Download

Comment 1 by marq@chromium.org, Jun 26 2018

Cc: marq@chromium.org
Labels: -Pri-1 -Proj-UIRefresh Pri-2
Owner: martijnb@chromium.org
Status: Assigned (was: Untriaged)
This background is only used in the non-UIRefresh tab switchers, not in the new tab grid. It will be deleted when that code is deleted after M70 branch. Is this a change we want to make before then?

(removing the Proj-UIRefresh label, since this isn't a UIRefresh feature).
Yeah we should make this change before then if possible (so that it makes it in M69).

Comment 3 by marq@chromium.org, Jun 27 2018

Just to be clear: are you saying that this change *which doesn't affect the UI Refresh work* is important to get into M69? Can you explain why you feel this is a priority on a par with the UI Refresh?
I think this must be a misunderstanding. Pete probably means that we need to have the tab grid background as Solid #222222 (for UI Refresh Phase 1). Pete: Please confirm. 
Thanks.

Comment 5 Deleted

Cc: -marq@chromium.org martijnb@chromium.org
Labels: Proj-UIRefresh
Owner: justincohen@chromium.org
As per offline discussion, proposed to use startup screen.
IMG_0944.PNG
214 KB View Download
Labels: -Pri-2 Q2 Pri-1
Labels: ReleaseBlock-Stable M-69
Got it, I'll use the current startup image as the shield to hide incognito.  Thanks!
Status: Started (was: Assigned)
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 27 2018

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c76065c44e6e0ced7c1c956d394633590a33057

commit 9c76065c44e6e0ced7c1c956d394633590a33057
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jun 27 16:46:33 2018

[ios] Use launch screen for incognito blocker.

Bug:  852705 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I611e9625e988e077f61e71e58a7f44b741a20eab
Reviewed-on: https://chromium-review.googlesource.com/1116702
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570800}
[modify] https://crrev.com/9c76065c44e6e0ced7c1c956d394633590a33057/ios/chrome/app/application_delegate/app_state.mm

Labels: OS-iOS
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Launch screen is now displayed as incognito shield.
Verified on M69.0.3480.0 canary
iOS: 11.4, 12, 10.3.3
Device: iPad Pro, iPhoneX, iPhone5S

Sign in to add a comment