New issue
Advanced search Search tips

Issue 852701 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Support content-hint of type "text" for MediaStreamTrack

Project Member Reported by hta@chromium.org, Jun 14 2018

Issue description

The content-hint specification (https://w3c.github.io/mst-content-hint/) has added a new value "text" as per https://github.com/w3c/mst-content-hint/pull/25.

This should be supported before shipping the attribute.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/c19ab07134aff75025f88c02a3356313078bb281

commit c19ab07134aff75025f88c02a3356313078bb281
Author: Harald Alvestrand <hta@webrtc.org>
Date: Thu Jun 21 11:29:20 2018

Add support for content-hint value "text"

This involves treating it just like "detailed", for now.
At a later stage we might want to modify codec parameters for it.

Bug:  chromium:852701 
Change-Id: I24678e1f7711bf03ca22273afaaf338e9e3ba1fe
Reviewed-on: https://webrtc-review.googlesource.com/83582
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Peter Boström <pbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23701}
[modify] https://crrev.com/c19ab07134aff75025f88c02a3356313078bb281/api/mediastreaminterface.h
[modify] https://crrev.com/c19ab07134aff75025f88c02a3356313078bb281/pc/rtpsender.cc
[modify] https://crrev.com/c19ab07134aff75025f88c02a3356313078bb281/pc/rtpsenderreceiver_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24a312005a08f414a2946e9c39495356b5d61917

commit 24a312005a08f414a2946e9c39495356b5d61917
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Jun 21 18:50:17 2018

Roll src/third_party/webrtc 8b23dba0e50f..6f440ed5b51f (12 commits)

https://webrtc.googlesource.com/src.git/+log/8b23dba0e50f..6f440ed5b51f


git log 8b23dba0e50f..6f440ed5b51f --date=short --no-merges --format='%ad %ae %s'
2018-06-21 mbonadei@webrtc.org Revert "Implement H264 simulcast support and generalize SimulcastEncoderAdapter use for H264 & VP8."
2018-06-21 saza@webrtc.org Add AGC1 fuzzer
2018-06-21 titovartem@webrtc.org Revert "Roll chromium_revision e1ef7d4b6b..b47e7752c6 (568794:569173)"
2018-06-21 danilchap@webrtc.org Replace rtc::Optional with absl::optional in api
2018-06-21 henrik.lundin@webrtc.org Revert "NetEq: Deprecate playout modes Fax, Off and Streaming"
2018-06-21 sergio.garcia.murillo@gmail.com Implement H264 simulcast support and generalize SimulcastEncoderAdapter use for H264 & VP8.
2018-06-21 henrik.lundin@webrtc.org NetEq: Deprecate playout modes Fax, Off and Streaming
2018-06-21 titovartem@webrtc.org Remove third party dependecies that are not more in the source code
2018-06-21 titovartem@webrtc.org Remove usage of rtc_base/checks.h in 3pp base64.cc
2018-06-21 hta@webrtc.org Add support for content-hint value "text"
2018-06-21 danilchap@webrtc.org Replace rtc::Optional with absl::optional in rtc_base
2018-06-21 yura.yaroshevich@gmail.com Fixed crash when PCF is destroyed before MediaStream in ObjC


Created with:
  gclient setdep -r src/third_party/webrtc@6f440ed5b51f

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:852701
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iabcf02d7b06e664bc318ed997f788ed78c928745
Reviewed-on: https://chromium-review.googlesource.com/1110278
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569340}
[modify] https://crrev.com/24a312005a08f414a2946e9c39495356b5d61917/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/054f161cf50c01ab1940ee28c11133a947fcb81a

commit 054f161cf50c01ab1940ee28c11133a947fcb81a
Author: Harald Alvestrand <hta@chromium.org>
Date: Wed Jun 27 10:14:22 2018

Add support for content-hint value "text"

At this time, it is treated the same as "detailed".

Bug:  chromium:852701 
Change-Id: I145c0ac9f93d2152aa5ac4a84a4a7f858c4f3fc3
Reviewed-on: https://chromium-review.googlesource.com/1111957
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570719}
[modify] https://crrev.com/054f161cf50c01ab1940ee28c11133a947fcb81a/content/renderer/media/webrtc/media_stream_video_webrtc_sink.cc
[modify] https://crrev.com/054f161cf50c01ab1940ee28c11133a947fcb81a/content/renderer/media/webrtc/webrtc_video_capturer_adapter.cc
[modify] https://crrev.com/054f161cf50c01ab1940ee28c11133a947fcb81a/content/renderer/media/webrtc/webrtc_video_capturer_adapter_unittest.cc
[modify] https://crrev.com/054f161cf50c01ab1940ee28c11133a947fcb81a/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-contentHint.html
[modify] https://crrev.com/054f161cf50c01ab1940ee28c11133a947fcb81a/third_party/blink/public/platform/web_media_stream_track.h
[modify] https://crrev.com/054f161cf50c01ab1940ee28c11133a947fcb81a/third_party/blink/renderer/modules/mediastream/media_stream_track.cc
[modify] https://crrev.com/054f161cf50c01ab1940ee28c11133a947fcb81a/third_party/blink/renderer/platform/mediastream/media_stream_component.cc

Comment 4 by hta@chromium.org, Jun 27 2018

Status: Fixed (was: Untriaged)
Components: Blink>WebRTC
Labels: M-69

Sign in to add a comment