New issue
Advanced search Search tips

Issue 852698 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 846235



Sign in to add a comment

Add PageLoadMetrics.Clients.ServiceWorker.PaintTiming.NavigationToFirstPaint

Project Member Reported by falken@chromium.org, Jun 14 2018

Issue description

Time to first paint is listed as a high confidence loading metric, but we don't have it yet for ServiceWorker controlled page loads. Seems useful to have.
 
Blocking: 846235
Owner: shimazu@chromium.org
Status: Started (was: Available)
Summary: Add PageLoadMetrics.Clients.ServiceWorker.PaintTiming.NavigationToFirstPaint (was: Add PageLoadMetrics.Clients.ServiceWorker.PaintTiming.TimeToFirstPaint)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56e6ce24e659c3ae732ecdfb36e25f9c02da5057

commit 56e6ce24e659c3ae732ecdfb36e25f9c02da5057
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Jun 20 15:41:39 2018

Add PageLoad.Clients.ServiceWorker.PaintTiming.NavigationToFirstPaint

PaintTiming.NavigationToFirstPaint is one of key loading metrics, and we'd add
it before starting ServceWorkerServicification (a.k.a NetS13nServiceWorker)
experiement.

Bug:  852698 
Change-Id: I2d7b7ad9ef3df94d428e1fbcbc1148de27e45c6a
Reviewed-on: https://chromium-review.googlesource.com/1107418
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568851}
[modify] https://crrev.com/56e6ce24e659c3ae732ecdfb36e25f9c02da5057/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc
[modify] https://crrev.com/56e6ce24e659c3ae732ecdfb36e25f9c02da5057/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h
[modify] https://crrev.com/56e6ce24e659c3ae732ecdfb36e25f9c02da5057/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/56e6ce24e659c3ae732ecdfb36e25f9c02da5057/tools/metrics/histograms/histograms.xml

Comment 4 by falken@chromium.org, Jun 20 2018

Labels: M-69
Status: Fixed (was: Started)

Sign in to add a comment