New issue
Advanced search Search tips

Issue 852697 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ReattachDevToolsWindow browser_test failing on chromium.mac/Mac10.11 Tests

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 14 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rhalavati@google.com

browser_tests failing on chromium.mac/Mac10.11 Tests

Builders failed on: 
- Mac10.11 Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests


 
ReattachDevToolsWindow very occasionally fails, disabling it for Mac.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4489c4d019b9a4c45fb5138db7ee9ddcb681bfc

commit b4489c4d019b9a4c45fb5138db7ee9ddcb681bfc
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Jun 14 09:06:16 2018

Disable failing test on Mac: ReattachDevToolsWindow

BrowserTest.ReattachDevToolsWindow occasionally fails on Mac 10.11.

Bug: 852697
Change-Id: Ibd94a9b94d7963825c42dbe50fb8c72097409da0
TBR: ellyjones@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1100465
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567201}
[modify] https://crrev.com/b4489c4d019b9a4c45fb5138db7ee9ddcb681bfc/chrome/browser/ui/browser_browsertest.cc

Cc: treib@chromium.org
Adding test author to CC.
Cc: -rhalavati@google.com rhalavati@chromium.org

Comment 5 by treib@chromium.org, Jun 14 2018

Components: Tests>Flaky
Labels: BrowserTest.ReattachDevToolsWindow Type-Bug-Regression
Flakiness dashboard link:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=ReattachDevToolsWindow

Looks like the earliest failure was at 6/12/2018 7:47:38 PM GMT+2, and after that it mostly failed. It's failing only on 10.11 and 10.12 though, both 10.10 and 10.13 are fine?!

Comment 6 by treib@chromium.org, Jun 14 2018

There were also some pretty big general problems with browser_tests on Mac recently [1], maybe this is just part of that?

[1] https://groups.google.com/a/chromium.org/d/topic/chromium-dev/dnwMoZfTyos/discussion

Comment 7 by treib@chromium.org, Jun 14 2018

Components: Platform>DevTools
Labels: OS-Mac
Labels: Pri-1
Labels: -Sheriff-Chromium
Owner: treib@chromium.org
reassing to treib to re-enable/follow-up on? Feel free to delegate. Removing from the sheriff queue.
Labels: Test-Disabled
Status: Assigned (was: Available)

Comment 11 by treib@chromium.org, Jun 18 2018

 Issue 852326  has been merged into this issue.

Comment 12 by treib@chromium.org, Jun 18 2018

Cc: ellyjo...@chromium.org
Owner: lgrey@chromium.org
While I did write that test a while back, I'm not actually very familiar with this code, or with Mac in general. Over to Mac experts who can hopefully help or triage further.
Components: -Platform>DevTools

Sign in to add a comment